chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java - Issue 2536873002: Clean up VR Shell mode transitions (and fix potential webvr startup race).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java

Issue 2536873002: Clean up VR Shell mode transitions (and fix potential webvr startup race). (Closed)

Patch Set: Address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java

index 833dabd015921cd013fd5c84bc40c950cb5fc68c..204b63076d607bace530155114e92ce24c3117d9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java

@@ -16,7 +16,7 @@ public interface VrShell {

/**

* Performs native VrShell initialization.

- void initializeNative(Tab currentTab, VrShellDelegate delegate);

+ void initializeNative(Tab currentTab, VrShellDelegate delegate, boolean forWebVR);

/**

* Pauses VrShell.

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java » ('j') | no next file with comments »