Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/android/vr_shell/ui_interface.h

Issue 2536873002: Clean up VR Shell mode transitions (and fix potential webvr startup race). (Closed)
Patch Set: Update javascript Mode enum Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java ('k') | chrome/browser/android/vr_shell/ui_interface.cc » ('j') | chrome/browser/android/vr_shell/vr_shell.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/ui_interface.h
diff --git a/chrome/browser/android/vr_shell/ui_interface.h b/chrome/browser/android/vr_shell/ui_interface.h
index 474e7aadc3b66b94f05e4718da090cd458c61cf3..f1ed9e820cd5c813f6ea52fc9806cf00da854509 100644
--- a/chrome/browser/android/vr_shell/ui_interface.h
+++ b/chrome/browser/android/vr_shell/ui_interface.h
@@ -24,11 +24,12 @@ class UiInterface {
enum Mode {
STANDARD,
WEB_VR,
- MENU,
CINEMA,
+ STANDARD_MENU,
bshe 2016/11/28 22:15:07 nit: can you add comments about the two new enum?
mthiesse 2016/11/28 23:28:34 Acknowledged.
+ WEB_VR_MENU,
};
- UiInterface();
+ explicit UiInterface(Mode initial_mode);
virtual ~UiInterface();
void SetMode(Mode mode);
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java ('k') | chrome/browser/android/vr_shell/ui_interface.cc » ('j') | chrome/browser/android/vr_shell/vr_shell.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698