Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2536823002: Do not explicitly allow singletons in AudioDeviceThread. (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not explicitly allow singletons in AudioDeviceThread. Singletons are allowed by default on joinable threads. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a97236904b378427ffdc0db1fc658e5f1d1b57e1 Cr-Commit-Position: refs/heads/master@{#434908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M media/audio/audio_device_thread.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
fdoray
PTAL
4 years ago (2016-11-28 22:42:35 UTC) #7
tommi (sloooow) - chröme
I don't recall why this was needed. Guess tests will tell us if there's still ...
4 years ago (2016-11-29 06:03:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536823002/1
4 years ago (2016-11-29 06:04:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 06:09:43 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-29 06:13:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a97236904b378427ffdc0db1fc658e5f1d1b57e1
Cr-Commit-Position: refs/heads/master@{#434908}

Powered by Google App Engine
This is Rietveld 408576698