Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2536783003:
Ensure consistent error handling on 32b/64b platforms. (Closed)
|
Created:
4 years ago by vogelheim Modified:
4 years ago Reviewers:
Toon Verwaest CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionEnsure consistent error handling on 32b/64b platforms.
BUG=chromium:669017
Committed: https://crrev.com/c44008b01f69785f4487c46afb15f971290baf5a
Cr-Commit-Position: refs/heads/master@{#41364}
Patch Set 1 : Regression test only, to verify it's really 32b-vs-64b. #Patch Set 2 : Fix. #Patch Set 3 : Edge cases. There are so many of them. #Patch Set 4 : Message test instead of mjsunit. #
Messages
Total messages: 29 (20 generated)
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
vogelheim@chromium.org changed reviewers: + verwaest@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/16983) v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)
On 2016/11/29 09:26:40, vogelheim wrote: Meeh. "Fix" breaks other stuff. I'll try again... :-/
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Can we maybe get a test in the message test suite for this rather than an mjsunit test?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/29 10:49:41, Michael Achenbach wrote: > Can we maybe get a test in the message test suite for this rather than an > mjsunit test? Done. Not entirely sure why, though.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
now ptal. :)
lgtm
The CQ bit was checked by vogelheim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480431842305520,
"parent_rev": "a285bd7c3fdb978d7186aef51881b5c0556b4d58", "commit_rev":
"a9e54f796b1c116f464202377f859133c00fa5f0"}
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Ensure consistent error handling on 32b/64b platforms. BUG=chromium:669017 ========== to ========== Ensure consistent error handling on 32b/64b platforms. BUG=chromium:669017 Committed: https://crrev.com/c44008b01f69785f4487c46afb15f971290baf5a Cr-Commit-Position: refs/heads/master@{#41364} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/c44008b01f69785f4487c46afb15f971290baf5a Cr-Commit-Position: refs/heads/master@{#41364} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
