Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2536783002: Remove superfluous closeUI call (Closed)

Created:
4 years ago by rwlbuis
Modified:
4 years ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove superfluous closeUI call Remove superfluous closeUI call from onDismiss, this is already done in disconnectFromClientWithDebugMessage. BUG=587995 Committed: https://crrev.com/65814338da3efcfbcac4368a9725c6c48e8676c3 Cr-Commit-Position: refs/heads/master@{#434708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
rwlbuis
PTAL.
4 years ago (2016-11-28 17:52:18 UTC) #4
please use gerrit instead
lgtm
4 years ago (2016-11-28 18:10:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536783002/1
4 years ago (2016-11-28 18:10:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 20:26:52 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-28 20:29:34 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/65814338da3efcfbcac4368a9725c6c48e8676c3
Cr-Commit-Position: refs/heads/master@{#434708}

Powered by Google App Engine
This is Rietveld 408576698