Script blocking resources tracking should be only done by Document::isScriptExecutionReady

Script blocking resources tracking should be only done by Document::isScriptExecutionReady

Before this CL, we had a duplicated tracking flag
HTMLScriptRunner::m_hasScriptsWaitingForResources.

This CL removes the flag in HTMLScriptRunner and changes code so it checks
Document::isScriptExecutionReady() state instead.

This CL also removes a comment referring to HTMLDocumentParser::executeScriptsWaitingForResources
being called when it hasScriptsWaitingForResources as it should never happen
and replaces it with a DCHECK

BUG=None

Committed: https://crrev.com/74341a4386cbe0c0b94eba0535fbbbf8d1aff8ea
Cr-Commit-Position: refs/heads/master@{#434935}

[kouhei (in TOK), 2016-11-29 01:09:08]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 01:10:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kouhei (in TOK), 2016-11-29 01:10:34]

kouhei@chromium.org changed reviewers:
+ dominicc@chromium.org, yhirano@chromium.org

[commit-bot: I haz the power, 2016-11-29 02:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 02:29:25]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yhirano, 2016-11-29 04:44:56]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 04:45:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kouhei (in TOK), 2016-11-29 04:46:36]

working on test failures

[kouhei (in TOK), 2016-11-29 06:56:14]

https://codereview.chromium.org/2536753003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp (left):

https://codereview.chromium.org/2536753003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp:1107: if
(!m_scriptRunner->hasScriptsWaitingForResources())
Actually, this is a bug as it refers to the stale cached copy of
Document::isScriptExecutionReady.

[kouhei (in TOK), 2016-11-29 06:56:23]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 06:56:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominicc (has gone to gerrit), 2016-11-29 08:03:49]

LGTM

[commit-bot: I haz the power, 2016-11-29 08:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 08:29:07]

Dry run: This issue passed the CQ dry run.

[kouhei (in TOK), 2016-11-29 09:16:44]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2016-11-29 09:17:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 09:21:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480411004756930,
"parent_rev": "f9ebe50238b75c6b6e6ec711054b9d3ad17a1f9c", "commit_rev":
"e0b3995c97c81f8de315c5eb37626b15ef9fdcfc"}

[commit-bot: I haz the power, 2016-11-29 09:22:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-29 09:34:41]

Description was changed from

==========
Script blocking resources tracking should be only done by
Document::isScriptExecutionReady

Before this CL, we had a duplicated tracking flag
HTMLScriptRunner::m_hasScriptsWaitingForResources.

This CL removes the flag in HTMLScriptRunner and changes code so it checks
Document::isScriptExecutionReady() state instead.

This CL also removes a comment referring to
HTMLDocumentParser::executeScriptsWaitingForResources
being called when it hasScriptsWaitingForResources as it should never happen
and replaces it with a DCHECK

BUG=None
==========

to

==========
Script blocking resources tracking should be only done by
Document::isScriptExecutionReady

Before this CL, we had a duplicated tracking flag
HTMLScriptRunner::m_hasScriptsWaitingForResources.

This CL removes the flag in HTMLScriptRunner and changes code so it checks
Document::isScriptExecutionReady() state instead.

This CL also removes a comment referring to
HTMLDocumentParser::executeScriptsWaitingForResources
being called when it hasScriptsWaitingForResources as it should never happen
and replaces it with a DCHECK

BUG=None

Committed: https://crrev.com/74341a4386cbe0c0b94eba0535fbbbf8d1aff8ea
Cr-Commit-Position: refs/heads/master@{#434935}
==========

[commit-bot: I haz the power, 2016-11-29 09:34:41]

Patchset 3 (id:??) landed as
https://crrev.com/74341a4386cbe0c0b94eba0535fbbbf8d1aff8ea
Cr-Commit-Position: refs/heads/master@{#434935}

[battre, 2016-11-29 11:41:35]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2540653002/ by battre@chromium.org.

The reason for reverting is: Speculative revert for crbug.com/669435.

BUG=669435.