Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 2536723008: Make some small tweaks to the build instructions. (Closed)

Created:
4 years ago by Sidney San Martín
Modified:
4 years ago
Reviewers:
Dirk Pranke, teresam
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make some small tweaks to the build instructions. - Standardize on fenced code blocks, add 'shell' where appropriate. - Add '$' to shell commands where missing. - Add `code` marks to more identifiers. - Minor stylistic/grammatical suggestions. R=dpranke@chromium.org, teresam@google.com Committed: https://crrev.com/93387fa96af6f157cbd1ea44953620b346df2d56 Cr-Commit-Position: refs/heads/master@{#435508}

Patch Set 1 #

Total comments: 11

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+482 lines, -344 lines) Patch
M docs/android_build_instructions.md View 1 1 chunk +82 lines, -56 lines 0 comments Download
M docs/ios_build_instructions.md View 1 3 chunks +88 lines, -66 lines 0 comments Download
M docs/linux_arch_build_instructions.md View 1 1 chunk +12 lines, -9 lines 0 comments Download
M docs/linux_build_instructions.md View 1 5 chunks +85 lines, -59 lines 0 comments Download
M docs/linux_debian_build_instructions.md View 1 chunk +5 lines, -5 lines 0 comments Download
M docs/linux_fedora_build_instructions.md View 1 chunk +16 lines, -14 lines 0 comments Download
M docs/linux_mandriva_build_instructions.md View 1 chunk +14 lines, -12 lines 0 comments Download
M docs/linux_open_suse_build_instructions.md View 1 2 chunks +23 lines, -15 lines 0 comments Download
M docs/mac_build_instructions.md View 1 4 chunks +121 lines, -82 lines 0 comments Download
M docs/windows_build_instructions.md View 1 1 chunk +36 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Sidney San Martín
Just missed my chance to comment on your CL yesterday, here are my suggestions. https://codereview.chromium.org/2536723008/diff/1/docs/linux_arch_build_instructions.md ...
4 years ago (2016-11-30 17:43:40 UTC) #3
Dirk Pranke
lgtm. Thanks for the careful eye and the many, many fixes and improvements! https://codereview.chromium.org/2536723008/diff/1/docs/android_build_instructions.md File ...
4 years ago (2016-11-30 23:40:20 UTC) #4
Sidney San Martín
Thanks! I made most of these changes, and propagated a couple of sections to the ...
4 years ago (2016-12-01 00:22:23 UTC) #5
Dirk Pranke
still lgtm. https://codereview.chromium.org/2536723008/diff/1/docs/android_build_instructions.md File docs/android_build_instructions.md (right): https://codereview.chromium.org/2536723008/diff/1/docs/android_build_instructions.md#newcode60 docs/android_build_instructions.md:60: assume you are now in that directory: ...
4 years ago (2016-12-01 00:33:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536723008/20001
4 years ago (2016-12-01 00:53:28 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 01:04:32 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-01 01:09:37 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93387fa96af6f157cbd1ea44953620b346df2d56
Cr-Commit-Position: refs/heads/master@{#435508}

Powered by Google App Engine
This is Rietveld 408576698