Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2536723007: Removed android scrolling fake mouse moves and device_supports_mouse (Closed)
Patch Set: Made checks mirror what previous logic Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index f6bfde1f5678cfd906f2c7c86955761b1670336e..ca3f2d2486155c0bb8f3b49c1ec6542c11aa0a68 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -326,8 +326,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
private OverscrollRefreshHandler mOverscrollRefreshHandler;
- private Runnable mFakeMouseMoveRunnable = null;
-
// Only valid when focused on a text / password field.
private ImeAdapter mImeAdapter;
@@ -1027,7 +1025,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
MotionEvent offsetEvent = createOffsetMotionEvent(event);
try {
- mContainerView.removeCallbacks(mFakeMouseMoveRunnable);
if (mNativeContentViewCore == 0) return false;
int eventAction = event.getActionMasked();
@@ -1622,7 +1619,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
if (!mEnableTouchHover.booleanValue()) return false;
}
- mContainerView.removeCallbacks(mFakeMouseMoveRunnable);
if (mNativeContentViewCore != 0) {
nativeSendMouseEvent(mNativeContentViewCore, event.getEventTime(), eventAction,
offset.getX(), offset.getY(), event.getPointerId(0), event.getPressure(0),
@@ -1654,20 +1650,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
event.getAxisValue(MotionEvent.AXIS_HSCROLL),
event.getAxisValue(MotionEvent.AXIS_VSCROLL),
mRenderCoordinates.getWheelScrollFactor());
-
- // TODO(mustaq): Delete mFakeMouseMoveRunnable, see crbug.com/492738
- mContainerView.removeCallbacks(mFakeMouseMoveRunnable);
- // Send a delayed onMouseMove event so that we end
- // up hovering over the right position after the scroll.
- final MotionEvent eventFakeMouseMove = MotionEvent.obtain(event);
- mFakeMouseMoveRunnable = new Runnable() {
- @Override
- public void run() {
- onHoverEvent(eventFakeMouseMove);
- eventFakeMouseMove.recycle();
- }
- };
- mContainerView.postDelayed(mFakeMouseMoveRunnable, 250);
return true;
case MotionEvent.ACTION_BUTTON_PRESS:
case MotionEvent.ACTION_BUTTON_RELEASE:

Powered by Google App Engine
This is Rietveld 408576698