Chromium Code Reviews| Index: appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py |
| diff --git a/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py b/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py |
| index bae4096c6d5d0edd8e7bb787c44c99a1db310b93..fb02ded1e7dc29f2ec85fae52dac6aef5d187140 100644 |
| --- a/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py |
| +++ b/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py |
| @@ -79,7 +79,6 @@ class ProcessBaseSwarmingTaskResultPipeline(BasePipeline): |
| 'server_query_interval_seconds') |
| task_started = False |
| task_completed = False |
| - tests_statuses = {} |
| step_name_no_platform = None |
| task = self._GetSwarmingTask(*call_args) |
| @@ -107,6 +106,15 @@ class ProcessBaseSwarmingTaskResultPipeline(BasePipeline): |
| if (task_state == swarming_util.STATE_COMPLETED and |
| int(exit_code) != swarming_util.TASK_FAILED): |
| outputs_ref = data.get('outputs_ref') |
| + if not outputs_ref: |
| + task.status = analysis_status.ERROR |
| + task.error = { |
| + 'code': swarming_util.NO_TASK_OUTPUTS, |
| + 'message': 'outputs_ref is None' |
|
stgao
2016/11/30 00:21:35
In what situation there is no outputs_ref? We shou
|
| + } |
| + task.put() |
| + break |
| + |
| output_json, error = swarming_util.GetSwarmingTaskFailureLog( |
| outputs_ref, self.HTTP_CLIENT) |