Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

Issue 2536723003: [Devtools] Removed DataGrid's hasChildren getter/setter to use functions (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 613 matching lines...) Expand 10 before | Expand all | Expand 10 after
624 callback(target.runtimeModel.createRemoteObjectFromPrimitiveValue(this._na me)); 624 callback(target.runtimeModel.createRemoteObjectFromPrimitiveValue(this._na me));
625 else 625 else
626 target.heapProfilerAgent().getObjectByHeapObjectId(String(this.snapshotNod eId), objectGroupName, formatResult); 626 target.heapProfilerAgent().getObjectByHeapObjectId(String(this.snapshotNod eId), objectGroupName, formatResult);
627 } 627 }
628 628
629 updateHasChildren() { 629 updateHasChildren() {
630 /** 630 /**
631 * @this {Profiler.HeapSnapshotGenericObjectNode} 631 * @this {Profiler.HeapSnapshotGenericObjectNode}
632 */ 632 */
633 function isEmptyCallback(isEmpty) { 633 function isEmptyCallback(isEmpty) {
634 this.hasChildren = !isEmpty; 634 this.setHasChildren(!isEmpty);
635 } 635 }
636 this._provider().isEmpty(isEmptyCallback.bind(this)); 636 this._provider().isEmpty(isEmptyCallback.bind(this));
637 } 637 }
638 638
639 /** 639 /**
640 * @param {string} fullName 640 * @param {string} fullName
641 * @param {boolean} hasObjectId 641 * @param {boolean} hasObjectId
642 * @return {string} 642 * @return {string}
643 */ 643 */
644 shortenWindowURL(fullName, hasObjectId) { 644 shortenWindowURL(fullName, hasObjectId) {
(...skipping 795 matching lines...) Expand 10 before | Expand all | Expand 10 after
1440 return cell; 1440 return cell;
1441 } 1441 }
1442 1442
1443 /** 1443 /**
1444 * @return {number} 1444 * @return {number}
1445 */ 1445 */
1446 allocationNodeId() { 1446 allocationNodeId() {
1447 return this._allocationNode.id; 1447 return this._allocationNode.id;
1448 } 1448 }
1449 }; 1449 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698