Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js

Issue 2536723003: [Devtools] Removed DataGrid's hasChildren getter/setter to use functions (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 var initialize_HeapSnapshotTest = function() { 1 var initialize_HeapSnapshotTest = function() {
2 2
3 InspectorTest.preloadPanel("profiles"); 3 InspectorTest.preloadPanel("profiles");
4 4
5 InspectorTest.createHeapSnapshotMockFactories = function() { 5 InspectorTest.createHeapSnapshotMockFactories = function() {
6 6
7 InspectorTest.createJSHeapSnapshotMockObject = function() 7 InspectorTest.createJSHeapSnapshotMockObject = function()
8 { 8 {
9 return { 9 return {
10 _rootNodeIndex: 0, 10 _rootNodeIndex: 0,
(...skipping 601 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 row.removeEventListener(Profiler.HeapSnapshotGridNode.Events.PopulateCom plete, populateComplete, this); 612 row.removeEventListener(Profiler.HeapSnapshotGridNode.Events.PopulateCom plete, populateComplete, this);
613 function callCallback() 613 function callCallback()
614 { 614 {
615 callback(row); 615 callback(row);
616 } 616 }
617 setTimeout(callCallback, 0); 617 setTimeout(callCallback, 0);
618 } 618 }
619 row.addEventListener(Profiler.HeapSnapshotGridNode.Events.PopulateComplete, populateComplete, this); 619 row.addEventListener(Profiler.HeapSnapshotGridNode.Events.PopulateComplete, populateComplete, this);
620 (function expand() 620 (function expand()
621 { 621 {
622 if (row.hasChildren) 622 if (row.hasChildren())
623 row.expand(); 623 row.expand();
624 else 624 else
625 setTimeout(expand, 0); 625 setTimeout(expand, 0);
626 })(); 626 })();
627 }; 627 };
628 628
629 InspectorTest.findAndExpandGCRoots = function(callback) 629 InspectorTest.findAndExpandGCRoots = function(callback)
630 { 630 {
631 InspectorTest.findAndExpandRow("(GC roots)", callback); 631 InspectorTest.findAndExpandRow("(GC roots)", callback);
632 }; 632 };
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
727 function sortingComplete() 727 function sortingComplete()
728 { 728 {
729 dataGrid.removeEventListener(Profiler.HeapSnapshotSortableDataGrid.E vents.SortingComplete, sortingComplete, null); 729 dataGrid.removeEventListener(Profiler.HeapSnapshotSortableDataGrid.E vents.SortingComplete, sortingComplete, null);
730 callback(); 730 callback();
731 } 731 }
732 dataGrid.addEventListener(Profiler.HeapSnapshotSortableDataGrid.Events.S ortingComplete, sortingComplete, null); 732 dataGrid.addEventListener(Profiler.HeapSnapshotSortableDataGrid.Events.S ortingComplete, sortingComplete, null);
733 } 733 }
734 }; 734 };
735 735
736 }; 736 };
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698