Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Issue 2536673002: Revert of [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. (patchset #2 id:20001 of https://codereview.chromium.org/2529343003/ ) Reason for revert: Seems to break TSAN builds. https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/12897/steps/Check/logs/stack-traces Original issue's description: > [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. > > This removes the supporting function to perform a range-lookup in the > exception handler table for unoptimized code. Such tables are by now > guaranteed to be empty, the deoptimizer cannot encounter this case. > > R=jarin@chromium.org > > Committed: https://crrev.com/1f27ed9d7da78904e0418364c6394f913eabbe70 > Cr-Commit-Position: refs/heads/master@{#41318} TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/54aac1f7787265e19c4b1d1f60690865c9e75ee8 Cr-Commit-Position: refs/heads/master@{#41319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M src/deoptimizer.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Starzinger
Created Revert of [deoptimizer] Remove dead Code::LookupRangeInHandlerTable.
4 years ago (2016-11-28 14:07:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536673002/1
4 years ago (2016-11-28 14:07:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 14:07:37 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-28 14:07:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54aac1f7787265e19c4b1d1f60690865c9e75ee8
Cr-Commit-Position: refs/heads/master@{#41319}

Powered by Google App Engine
This is Rietveld 408576698