Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2536643004: Remove obsolete flag and add guard flag for AAA (Closed)

Created:
4 years ago by liyuqian
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete flag and add guard flag for AAA We no longer use SK_ANALYTIC_AA flag it's now set as default in Chromium. However, we need some flag to guard some bug fixes in Skia wihtout breaking the Chromium layout tests. BUG= Committed: https://crrev.com/f7a721acbe44d2051a7f29aaf21e14d64060c404 Cr-Commit-Position: refs/heads/master@{#435036}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 15 (10 generated)
liyuqian
Please take a look at this flag change that allows me to fix bugs in ...
4 years ago (2016-11-29 14:40:58 UTC) #5
f(malita)
lgtm https://codereview.chromium.org/2536643004/diff/1/skia/config/SkUserConfig.h File skia/config/SkUserConfig.h (right): https://codereview.chromium.org/2536643004/diff/1/skia/config/SkUserConfig.h#newcode231 skia/config/SkUserConfig.h:231: #ifndef SK_ANALYTIC_AA_GUARD naming nit: maybe something like SK_SUPPORT_LEGACY_ANALYTIC_AA, ...
4 years ago (2016-11-29 14:44:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536643004/1
4 years ago (2016-11-29 18:17:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 18:27:17 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-29 18:31:58 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7a721acbe44d2051a7f29aaf21e14d64060c404
Cr-Commit-Position: refs/heads/master@{#435036}

Powered by Google App Engine
This is Rietveld 408576698