Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 253663002: WebGL: Wait for the sync point that the compositor inserted before deleting a mailbox. (Closed)

Created:
6 years, 8 months ago by dshwang
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

WebGL: Wait for the sync point that the compositor inserted before deleting a mailbox. BUG=344393 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172705

Patch Set 1 #

Patch Set 2 : Add tests #

Patch Set 3 : build fix due to -Werror=sign-compare #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -4 lines) Patch
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBufferTest.cpp View 1 2 5 chunks +49 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
dshwang
I made mistake in https://codereview.chromium.org/169933002 This CL fixes it; WebGL must wait for sync point ...
6 years, 8 months ago (2014-04-26 17:04:21 UTC) #1
Ken Russell (switch to Gerrit)
LGTM Please wait for the GPU try jobs to finish, then commit. I also had ...
6 years, 8 months ago (2014-04-26 17:50:23 UTC) #2
dshwang
On 2014/04/26 17:50:23, Ken Russell wrote: > LGTM > > Please wait for the GPU ...
6 years, 8 months ago (2014-04-26 18:58:28 UTC) #3
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 8 months ago (2014-04-26 18:58:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/253663002/20001
6 years, 8 months ago (2014-04-26 18:59:11 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 19:26:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-26 19:26:22 UTC) #7
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 8 months ago (2014-04-26 19:30:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/253663002/20001
6 years, 8 months ago (2014-04-26 19:31:19 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 19:37:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-26 19:37:11 UTC) #11
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 8 months ago (2014-04-26 22:13:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/253663002/40001
6 years, 8 months ago (2014-04-26 22:14:12 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 22:19:58 UTC) #14
Message was sent while issue was closed.
Change committed as 172705

Powered by Google App Engine
This is Rietveld 408576698