chrome/browser/extensions/api/module/module.cc - Issue 25366003: Moved some functions off ExtensionService into a new file extension_util.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/module/module.cc

Issue 25366003: Moved some functions off ExtensionService into a new file extension_util. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Compile failures Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/message_service.cc ('k') | chrome/browser/extensions/api/preference/preference_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/module/module.cc

diff --git a/chrome/browser/extensions/api/module/module.cc b/chrome/browser/extensions/api/module/module.cc

index b1295d1650a0d2296af0829ffa56e101c89cf0ef..31e849c1d534bcc62eb988ebba4afef6965dc2f9 100644

--- a/chrome/browser/extensions/api/module/module.cc

+++ b/chrome/browser/extensions/api/module/module.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/extensions/extension_prefs.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_system.h"

+#include "chrome/browser/extensions/extension_util.h"

#include "chrome/browser/profiles/profile.h"

namespace extensions {

@@ -51,7 +52,7 @@ bool ExtensionIsAllowedIncognitoAccessFunction::RunImpl() {

const Extension* extension = GetExtension();

SetResult(new base::FundamentalValue(

- ext_service->IsIncognitoEnabled(extension->id())));

+ extension_util::IsIncognitoEnabled(extension->id(), ext_service)));

return true;

}

@@ -61,7 +62,7 @@ bool ExtensionIsAllowedFileSchemeAccessFunction::RunImpl() {

const Extension* extension = GetExtension();

SetResult(new base::FundamentalValue(

- ext_service->AllowFileAccess(extension)));

+ extension_util::AllowFileAccess(extension, ext_service)));

return true;

}