Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2536593002:
Revise the description of ExternalStorageReadOnly to make it clearer. (Closed)
|
Created:
4 years ago by yamaguchi Modified:
4 years ago Reviewers:
Andrew T Wilson (Slow) CC:
chromium-reviews, tnagel+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevise the description of ExternalStorageReadOnly to make it clearer.
This is a follow-up of https://codereview.chromium.org/2526463002/ .
Here is the actual behavior of the system:
X=ExternaStorageDisabled
Y=ExternalStorageReadOnly
X Y
False False : Users can read from and write to external storage media.
False True : Users can read files in external storage, but cannot write to there.
True False : Users cannot access external storage at all.
True True : Users cannot access external storage at all.
If any of the policy value is not configured (=not exist), it is equivalent to false.
If ExternaStorageDisabled = true, any access to removable storage media are denied. In this case, ExternalStorageReadOnly will not be considered because the storage media devices itself will never be accessible by the user.
BUG=669004
Committed: https://crrev.com/c334558eef67b1216278c0f505a49a0948bc707d
Cr-Commit-Position: refs/heads/master@{#434644}
Patch Set 1 #Patch Set 2 : Rephrasing. #
Total comments: 2
Patch Set 3 : Change the order of paragraphs to describe the policy itself first, rather than interaction with ot… #Messages
Total messages: 20 (14 generated)
Description was changed from ========== Revise the description of ExternalStorageReadOnly to make it clearer. BUG=669004 ========== to ========== Revise the description of ExternalStorageReadOnly to make it clearer. Here is the actual behavior of the system: X=ExternaStorageDisabled Y=ExternalStorageReadOnly X Y False False : Users can read from and write to external storage media. False True : Users can read files in external storage, but cannot write to there. True False : Users cannot access external storage at all. True True : Users cannot access external storage at all. If ExternaStorageDisabled = true, any access to removable storage media are denied. In this case, ExternalStorageReadOnly will not be considered because the storage media devices itself will never be accessible by the user. The first sentence of the description need to describe this. BUG=669004 ==========
Description was changed from ========== Revise the description of ExternalStorageReadOnly to make it clearer. Here is the actual behavior of the system: X=ExternaStorageDisabled Y=ExternalStorageReadOnly X Y False False : Users can read from and write to external storage media. False True : Users can read files in external storage, but cannot write to there. True False : Users cannot access external storage at all. True True : Users cannot access external storage at all. If ExternaStorageDisabled = true, any access to removable storage media are denied. In this case, ExternalStorageReadOnly will not be considered because the storage media devices itself will never be accessible by the user. The first sentence of the description need to describe this. BUG=669004 ========== to ========== Revise the description of ExternalStorageReadOnly to make it clearer. Here is the actual behavior of the system: X=ExternaStorageDisabled Y=ExternalStorageReadOnly X Y False False : Users can read from and write to external storage media. False True : Users can read files in external storage, but cannot write to there. True False : Users cannot access external storage at all. True True : Users cannot access external storage at all. If any of the policy value is not configured (=not exist), it is equivalent to false. If ExternaStorageDisabled = true, any access to removable storage media are denied. In this case, ExternalStorageReadOnly will not be considered because the storage media devices itself will never be accessible by the user. The first sentence of the description need to describe this. BUG=669004 ==========
Description was changed from ========== Revise the description of ExternalStorageReadOnly to make it clearer. Here is the actual behavior of the system: X=ExternaStorageDisabled Y=ExternalStorageReadOnly X Y False False : Users can read from and write to external storage media. False True : Users can read files in external storage, but cannot write to there. True False : Users cannot access external storage at all. True True : Users cannot access external storage at all. If any of the policy value is not configured (=not exist), it is equivalent to false. If ExternaStorageDisabled = true, any access to removable storage media are denied. In this case, ExternalStorageReadOnly will not be considered because the storage media devices itself will never be accessible by the user. The first sentence of the description need to describe this. BUG=669004 ========== to ========== Revise the description of ExternalStorageReadOnly to make it clearer. This is a follow-up of https://codereview.chromium.org/2526463002/ . Here is the actual behavior of the system: X=ExternaStorageDisabled Y=ExternalStorageReadOnly X Y False False : Users can read from and write to external storage media. False True : Users can read files in external storage, but cannot write to there. True False : Users cannot access external storage at all. True True : Users cannot access external storage at all. If any of the policy value is not configured (=not exist), it is equivalent to false. If ExternaStorageDisabled = true, any access to removable storage media are denied. In this case, ExternalStorageReadOnly will not be considered because the storage media devices itself will never be accessible by the user. The first sentence of the description need to describe this. BUG=669004 ==========
yamaguchi@chromium.org changed reviewers: + atwilson@chromium.org
LGTM, but see my suggestion below. https://codereview.chromium.org/2536593002/diff/20001/components/policy/resou... File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2536593002/diff/20001/components/policy/resou... components/policy/resources/policy_templates.json:5817: 'desc': '''This policy takes effect only when ExternalStorageDisabled is set to false or not configured. I would move this description (interaction of this policy with ExternalStorageDisabled policy) to the end, since the most important part of this documentation is explaining what this policy does itself. Anyhow, this description is fine, but you might consider wording it something like: "The ExternalStorageDisabled policy takes precedence over this policy - if ExternalStorageDisabled is set to true, then all access to external storage is disabled and as a result this policy is ignored".
The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Revise the description of ExternalStorageReadOnly to make it clearer. This is a follow-up of https://codereview.chromium.org/2526463002/ . Here is the actual behavior of the system: X=ExternaStorageDisabled Y=ExternalStorageReadOnly X Y False False : Users can read from and write to external storage media. False True : Users can read files in external storage, but cannot write to there. True False : Users cannot access external storage at all. True True : Users cannot access external storage at all. If any of the policy value is not configured (=not exist), it is equivalent to false. If ExternaStorageDisabled = true, any access to removable storage media are denied. In this case, ExternalStorageReadOnly will not be considered because the storage media devices itself will never be accessible by the user. The first sentence of the description need to describe this. BUG=669004 ========== to ========== Revise the description of ExternalStorageReadOnly to make it clearer. This is a follow-up of https://codereview.chromium.org/2526463002/ . Here is the actual behavior of the system: X=ExternaStorageDisabled Y=ExternalStorageReadOnly X Y False False : Users can read from and write to external storage media. False True : Users can read files in external storage, but cannot write to there. True False : Users cannot access external storage at all. True True : Users cannot access external storage at all. If any of the policy value is not configured (=not exist), it is equivalent to false. If ExternaStorageDisabled = true, any access to removable storage media are denied. In this case, ExternalStorageReadOnly will not be considered because the storage media devices itself will never be accessible by the user. BUG=669004 ==========
https://codereview.chromium.org/2536593002/diff/20001/components/policy/resou... File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2536593002/diff/20001/components/policy/resou... components/policy/resources/policy_templates.json:5817: 'desc': '''This policy takes effect only when ExternalStorageDisabled is set to false or not configured. On 2016/11/28 12:05:18, Andrew T Wilson (Slow) wrote: > I would move this description (interaction of this policy with > ExternalStorageDisabled policy) to the end, since the most important part of > this documentation is explaining what this policy does itself. > > Anyhow, this description is fine, but you might consider wording it something > like: "The ExternalStorageDisabled policy takes precedence over this policy - if > ExternalStorageDisabled is set to true, then all access to external storage is > disabled and as a result this policy is ignored". Done. Thanks so much for your help!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yamaguchi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from atwilson@chromium.org Link to the patchset: https://codereview.chromium.org/2536593002/#ps40001 (title: "Change the order of paragraphs to describe the policy itself first, rather than interaction with ot…")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480338534071290,
"parent_rev": "c4eb1b6abd248336efac3874d027cc35b3fff912", "commit_rev":
"fa7826f520e5006b76b27a15c140037614a363c5"}
Message was sent while issue was closed.
Description was changed from ========== Revise the description of ExternalStorageReadOnly to make it clearer. This is a follow-up of https://codereview.chromium.org/2526463002/ . Here is the actual behavior of the system: X=ExternaStorageDisabled Y=ExternalStorageReadOnly X Y False False : Users can read from and write to external storage media. False True : Users can read files in external storage, but cannot write to there. True False : Users cannot access external storage at all. True True : Users cannot access external storage at all. If any of the policy value is not configured (=not exist), it is equivalent to false. If ExternaStorageDisabled = true, any access to removable storage media are denied. In this case, ExternalStorageReadOnly will not be considered because the storage media devices itself will never be accessible by the user. BUG=669004 ========== to ========== Revise the description of ExternalStorageReadOnly to make it clearer. This is a follow-up of https://codereview.chromium.org/2526463002/ . Here is the actual behavior of the system: X=ExternaStorageDisabled Y=ExternalStorageReadOnly X Y False False : Users can read from and write to external storage media. False True : Users can read files in external storage, but cannot write to there. True False : Users cannot access external storage at all. True True : Users cannot access external storage at all. If any of the policy value is not configured (=not exist), it is equivalent to false. If ExternaStorageDisabled = true, any access to removable storage media are denied. In this case, ExternalStorageReadOnly will not be considered because the storage media devices itself will never be accessible by the user. BUG=669004 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Revise the description of ExternalStorageReadOnly to make it clearer. This is a follow-up of https://codereview.chromium.org/2526463002/ . Here is the actual behavior of the system: X=ExternaStorageDisabled Y=ExternalStorageReadOnly X Y False False : Users can read from and write to external storage media. False True : Users can read files in external storage, but cannot write to there. True False : Users cannot access external storage at all. True True : Users cannot access external storage at all. If any of the policy value is not configured (=not exist), it is equivalent to false. If ExternaStorageDisabled = true, any access to removable storage media are denied. In this case, ExternalStorageReadOnly will not be considered because the storage media devices itself will never be accessible by the user. BUG=669004 ========== to ========== Revise the description of ExternalStorageReadOnly to make it clearer. This is a follow-up of https://codereview.chromium.org/2526463002/ . Here is the actual behavior of the system: X=ExternaStorageDisabled Y=ExternalStorageReadOnly X Y False False : Users can read from and write to external storage media. False True : Users can read files in external storage, but cannot write to there. True False : Users cannot access external storage at all. True True : Users cannot access external storage at all. If any of the policy value is not configured (=not exist), it is equivalent to false. If ExternaStorageDisabled = true, any access to removable storage media are denied. In this case, ExternalStorageReadOnly will not be considered because the storage media devices itself will never be accessible by the user. BUG=669004 Committed: https://crrev.com/c334558eef67b1216278c0f505a49a0948bc707d Cr-Commit-Position: refs/heads/master@{#434644} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c334558eef67b1216278c0f505a49a0948bc707d Cr-Commit-Position: refs/heads/master@{#434644} |
