Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2536573002: [debug] remove debug command processor from scope tests. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] remove debug command processor from scope tests. BUG=v8:5510 R=jgruber@chromium.org Committed: https://crrev.com/0398e5d5e4768f54f86ac9cfdaa5ae9d278cb575 Cr-Commit-Position: refs/heads/master@{#41311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -379 lines) Patch
M test/mjsunit/bugs/harmony/debug-blockscopes.js View 3 chunks +4 lines, -51 lines 0 comments Download
M test/mjsunit/debug-scopes.js View 34 chunks +66 lines, -85 lines 0 comments Download
M test/mjsunit/es6/debug-blockscopes.js View 3 chunks +4 lines, -52 lines 0 comments Download
M test/mjsunit/es6/generators-debug-scopes.js View 4 chunks +6 lines, -54 lines 0 comments Download
M test/mjsunit/harmony/async-function-debug-scopes.js View 2 chunks +0 lines, -57 lines 0 comments Download
M test/mjsunit/modules-debug-scopes1.js View 28 chunks +62 lines, -80 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
4 years ago (2016-11-28 10:56:45 UTC) #1
jgruber
lgtm
4 years ago (2016-11-28 11:17:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536573002/1
4 years ago (2016-11-28 11:22:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 12:01:22 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-28 12:01:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0398e5d5e4768f54f86ac9cfdaa5ae9d278cb575
Cr-Commit-Position: refs/heads/master@{#41311}

Powered by Google App Engine
This is Rietveld 408576698