third_party/WebKit/Source/core/dom/ScriptLoader.cpp - Issue 2536553002: Simplify: remove PendingScript::releaseElementAndClear

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

Issue 2536553002: Simplify: remove PendingScript::releaseElementAndClear (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

diff --git a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

index 6643e5e70a43bfba96a9c1534a44fe51a0e3c975..ff12ae9cb2411ed959a80ddcef381ef05bf7beb3 100644

--- a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

+++ b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

@@ -561,8 +561,7 @@ void ScriptLoader::execute() {

DCHECK(m_pendingScript->resource());

bool errorOccurred = false;

ScriptSourceCode source = m_pendingScript->getSource(KURL(), errorOccurred);

- Element* element = m_pendingScript->releaseElementAndClear();

- ALLOW_UNUSED_LOCAL(element);

+ m_pendingScript->dispose();

if (errorOccurred) {

dispatchErrorEvent();

} else if (!m_resource->wasCanceled()) {