Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 2536533002: memory coordinator: Check RenderProcessHost pointers before use them (Closed)

Created:
4 years ago by bashi
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

memory coordinator: Check RenderProcessHost pointers before use them RenderProcessHost::FromID() could return nullptrs. We should check it before using it. BUG=668924 Committed: https://crrev.com/1c34e42ac01d4698bacf17b785f24fb2b965e7ab Cr-Commit-Position: refs/heads/master@{#434611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/memory/memory_coordinator.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
bashi
PTAL
4 years ago (2016-11-28 03:24:33 UTC) #4
haraken
LGTM
4 years ago (2016-11-28 04:10:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536533002/1
4 years ago (2016-11-28 04:40:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 06:04:56 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-28 06:07:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c34e42ac01d4698bacf17b785f24fb2b965e7ab
Cr-Commit-Position: refs/heads/master@{#434611}

Powered by Google App Engine
This is Rietveld 408576698