Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2536523002:
Blink Animation: Extend Animation's GC lifetime if it has a finish promise. (Closed)
|
Created:
4 years ago by loyso (OOO) Modified:
4 years ago Reviewers:
alancutter (OOO until 2018) CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBlink Animation: Extend Animation's GC lifetime if it has a finish promise.
BUG=617539
Committed: https://crrev.com/bfbc065caf6187d00c0e549f07ad264bb1614873
Committed: https://crrev.com/0d1a666647b23289500c395a9fe5cca2011d9bc7
Cr-Original-Commit-Position: refs/heads/master@{#434612}
Cr-Commit-Position: refs/heads/master@{#434869}
Patch Set 1 #Patch Set 2 : Extend lifetime only if promise is pending. #Patch Set 3 : Fix memory leaks. #
Messages
Total messages: 32 (21 generated)
The CQ bit was checked by loyso@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Blink Animation: Extend Animation's GC lifetime if it has a finish promise. BUG=617539 ========== to ========== Blink Animation: Extend Animation's GC lifetime if it has a finish promise. BUG=617539 ==========
loyso@chromium.org changed reviewers: + alancutter@chromium.org
The CQ bit was checked by loyso@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by loyso@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480314665170770,
"parent_rev": "7605223b569f79dd1acb89553927bb4c6e0f6589", "commit_rev":
"5e2273f9639b1fcb22e1f99b58b434d6521615a7"}
Message was sent while issue was closed.
Description was changed from ========== Blink Animation: Extend Animation's GC lifetime if it has a finish promise. BUG=617539 ========== to ========== Blink Animation: Extend Animation's GC lifetime if it has a finish promise. BUG=617539 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Blink Animation: Extend Animation's GC lifetime if it has a finish promise. BUG=617539 ========== to ========== Blink Animation: Extend Animation's GC lifetime if it has a finish promise. BUG=617539 Committed: https://crrev.com/bfbc065caf6187d00c0e549f07ad264bb1614873 Cr-Commit-Position: refs/heads/master@{#434612} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/bfbc065caf6187d00c0e549f07ad264bb1614873 Cr-Commit-Position: refs/heads/master@{#434612}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2535793002/ by magjed@chromium.org. The reason for reverting is: Causes unexpected leaks in webkit_tests: web-animations-api/animation-finish-event-cancelled.html web-animations-api/animation-cancel-ready-finished-ordering.html imported/wpt/web-animations/interfaces/Animation/finished.html web-animations-api/animation-onfinish.html imported/wpt/web-animations/interfaces/Animation/oncancel.html http/tests/security/mixedContent/websocket/insecure-websocket-in-secure-page-worker.html https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu....
Message was sent while issue was closed.
Description was changed from ========== Blink Animation: Extend Animation's GC lifetime if it has a finish promise. BUG=617539 Committed: https://crrev.com/bfbc065caf6187d00c0e549f07ad264bb1614873 Cr-Commit-Position: refs/heads/master@{#434612} ========== to ========== Blink Animation: Extend Animation's GC lifetime if it has a finish promise. BUG=617539 Committed: https://crrev.com/bfbc065caf6187d00c0e549f07ad264bb1614873 Cr-Commit-Position: refs/heads/master@{#434612} ==========
I want to re-land it. alancutter@, PTAL!
The CQ bit was checked by loyso@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by loyso@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480389944876980,
"parent_rev": "d35da1e7a6838809ed351751d3ee201bdb965d45", "commit_rev":
"f1d76e4cc4eb80f40f306b0eaf927b4b3779b036"}
Message was sent while issue was closed.
Description was changed from ========== Blink Animation: Extend Animation's GC lifetime if it has a finish promise. BUG=617539 Committed: https://crrev.com/bfbc065caf6187d00c0e549f07ad264bb1614873 Cr-Commit-Position: refs/heads/master@{#434612} ========== to ========== Blink Animation: Extend Animation's GC lifetime if it has a finish promise. BUG=617539 Committed: https://crrev.com/bfbc065caf6187d00c0e549f07ad264bb1614873 Cr-Commit-Position: refs/heads/master@{#434612} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Blink Animation: Extend Animation's GC lifetime if it has a finish promise. BUG=617539 Committed: https://crrev.com/bfbc065caf6187d00c0e549f07ad264bb1614873 Cr-Commit-Position: refs/heads/master@{#434612} ========== to ========== Blink Animation: Extend Animation's GC lifetime if it has a finish promise. BUG=617539 Committed: https://crrev.com/bfbc065caf6187d00c0e549f07ad264bb1614873 Committed: https://crrev.com/0d1a666647b23289500c395a9fe5cca2011d9bc7 Cr-Original-Commit-Position: refs/heads/master@{#434612} Cr-Commit-Position: refs/heads/master@{#434869} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/0d1a666647b23289500c395a9fe5cca2011d9bc7 Cr-Commit-Position: refs/heads/master@{#434869} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
