CSS Filters: Reduce usage of webkit prefix in filter effect layout tests

CSS Filters: Reduce usage of webkit prefix in filter effect layout tests

BUG=668914
Committed: https://crrev.com/b8d51ae5d7c9d68c34e54186cf88b2ce0b4e51b7
Cr-Commit-Position: refs/heads/master@{#434610}

[Eric Willigers, 2016-11-28 01:30:25]

ericwilligers@chromium.org changed reviewers:
+ meade@chromium.org

[meade_UTC10, 2016-11-28 02:55:04]

This seems to result in a bunch of duplicate filter properties in lots of
places. I started commenting but there are a lot of them - could you please fix
them up and then I'll continue looking.

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/css3/filters/effect-reference-delete-crash.html
(right):

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/filters/effect-reference-delete-crash.html:7:
<img id="html" style="filter: url(#MyFilter); filter: url(#MyFilter);"
src="resources/reference.png">
Is it still necessary to have both here?

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/css3/filters/effect-reference-external.html
(right):

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/filters/effect-reference-external.html:6:
<img style="filter: url(resources/hueRotate.svg#MyFilter); filter:
url(resources/hueRotate.svg#MyFilter);" src="resources/reference.png">
Are these both necessary?

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/css3/filters/effect-reference-hidpi-hw.html
(right):

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/filters/effect-reference-hidpi-hw.html:27:
<img style="filter: url(#turbulence); filter: url(#turbulence); position:
absolute; top: 10px; left: 210px;" src="resources/reference.png"/>
Two more duplicates...

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/css3/filters/effect-reference-hidpi.html
(right):

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/filters/effect-reference-hidpi.html:26: <img
style="filter: url(#turbulence); filter: url(#turbulence); position: absolute;
top: 10px; left: 210px;" src="resources/reference.png"/>
Another couple of duplicates

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/css3/filters/effect-reference-subregion-hidpi-hw.html
(right):

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/filters/effect-reference-subregion-hidpi-hw.html:17:
filter: url(#colormatrix);
Is it still necessary to have both of these?

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/css3/filters/effect-reference-subregion-nested.html
(right):

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/filters/effect-reference-subregion-nested.html:11:
filter: url(#merge);
Another new duplicate

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/css3/filters/effect-reference-subregion-zoom-hw.html
(right):

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/filters/effect-reference-subregion-zoom-hw.html:4:
filter: url(#colormatrix);
Another new duplicate

[Eric Willigers, 2016-11-28 03:54:46]

Remove duplicates. Apologies.

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/css3/filters/effect-reference-delete-crash.html
(right):

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/filters/effect-reference-delete-crash.html:7:
<img id="html" style="filter: url(#MyFilter); filter: url(#MyFilter);"
src="resources/reference.png">
On 2016/11/28 02:55:04, Eddy wrote:
> Is it still necessary to have both here?

Done.

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/css3/filters/effect-reference-external.html
(right):

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/filters/effect-reference-external.html:6:
<img style="filter: url(resources/hueRotate.svg#MyFilter); filter:
url(resources/hueRotate.svg#MyFilter);" src="resources/reference.png">
On 2016/11/28 02:55:04, Eddy wrote:
> Are these both necessary?

Done.

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/css3/filters/effect-reference-hidpi-hw.html
(right):

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/filters/effect-reference-hidpi-hw.html:27:
<img style="filter: url(#turbulence); filter: url(#turbulence); position:
absolute; top: 10px; left: 210px;" src="resources/reference.png"/>
On 2016/11/28 02:55:04, Eddy wrote:
> Two more duplicates...

Done.

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/css3/filters/effect-reference-hidpi.html
(right):

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/filters/effect-reference-hidpi.html:26: <img
style="filter: url(#turbulence); filter: url(#turbulence); position: absolute;
top: 10px; left: 210px;" src="resources/reference.png"/>
On 2016/11/28 02:55:04, Eddy wrote:
> Another couple of duplicates

Done.

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/css3/filters/effect-reference-subregion-hidpi-hw.html
(right):

https://codereview.chromium.org/2536503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/filters/effect-reference-subregion-hidpi-hw.html:17:
filter: url(#colormatrix);
On 2016/11/28 02:55:04, Eddy wrote:
> Is it still necessary to have both of these?

Done.

[meade_UTC10, 2016-11-28 04:36:49]

lgtm

[Eric Willigers, 2016-11-28 05:00:05]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-11-28 05:00:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 05:55:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480309205329500,
"parent_rev": "650b5362f1c62ecbe7602af8153356df8ad5ebcf", "commit_rev":
"6f990b0414cd7085ddd5e11a017bb6b15bde48d6"}

[commit-bot: I haz the power, 2016-11-28 05:56:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-28 05:59:15]

Description was changed from

==========
CSS Filters: Reduce usage of webkit prefix in filter effect layout tests

BUG=668914
==========

to

==========
CSS Filters: Reduce usage of webkit prefix in filter effect layout tests

BUG=668914

Committed: https://crrev.com/b8d51ae5d7c9d68c34e54186cf88b2ce0b4e51b7
Cr-Commit-Position: refs/heads/master@{#434610}
==========

[commit-bot: I haz the power, 2016-11-28 05:59:16]

Patchset 2 (id:??) landed as
https://crrev.com/b8d51ae5d7c9d68c34e54186cf88b2ce0b4e51b7
Cr-Commit-Position: refs/heads/master@{#434610}