Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h

Issue 2536493002: Let SVGForeignObject's local SVG coordinates mean what it should (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h
index 598a56f62704a3c2c694038bf6ff8bedec9b18e4..cfc5c091dfdf82ac65789dfb72ad3500084ea6ea 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h
@@ -26,10 +26,19 @@ namespace blink {
class SVGElement;
+// A common class of SVG objects that delegate layout, paint, etc. tasks to
+// LayoutBlockFlow. It has two coordinate spaces:
+// - local SVG coordinate space: similar to LayoutSVGModelObject, the space
+// that localSVGTransform() applies.
+// - local HTML coordinate space: defined by frameRect() as if the local SVG
+// coordinate space created a containing block. Like other LayoutBlockFlow
+// objects, LayoutSVGBlock's frameRect() is also in physical coordinates with
+// flipped blocks direction in the "containing block".
class LayoutSVGBlock : public LayoutBlockFlow {
public:
explicit LayoutSVGBlock(SVGElement*);
+ // These mapping functions map coordinates in HTML spaces.
void mapLocalToAncestor(const LayoutBoxModelObject* ancestor,
TransformState&,
MapCoordinatesFlags = ApplyContainerFlip) const final;
@@ -39,6 +48,10 @@ class LayoutSVGBlock : public LayoutBlockFlow {
const LayoutObject* pushMappingToContainer(
const LayoutBoxModelObject* ancestorToStopAt,
LayoutGeometryMap&) const final;
+ bool mapToVisualRectInAncestorSpace(
+ const LayoutBoxModelObject* ancestor,
+ LayoutRect&,
+ VisualRectFlags = DefaultVisualRectFlags) const final;
AffineTransform localSVGTransform() const final { return m_localTransform; }
@@ -46,10 +59,6 @@ class LayoutSVGBlock : public LayoutBlockFlow {
protected:
void willBeDestroyed() override;
- bool mapToVisualRectInAncestorSpace(
- const LayoutBoxModelObject* ancestor,
- LayoutRect&,
- VisualRectFlags = DefaultVisualRectFlags) const final;
AffineTransform m_localTransform;
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.h ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698