third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp - Issue 2536453002: Rename some functions about layout locations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

Issue 2536453002: Rename some functions about layout locations (Closed)

Patch Set: Add test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp ('k') | third_party/WebKit/Source/core/layout/line/DEPS » ('j') | third_party/WebKit/Source/core/layout/line/InlineBox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

diff --git a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

index 207bd03e4206d4767929569812a691569581d6de..d2154a764a9e0673bd3fee9bff272e00f89e256d 100644

--- a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

+++ b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

@@ -127,12 +127,12 @@ LayoutSize MultiColumnFragmentainerGroup::flowThreadTranslationAtOffset(

LayoutRect portionRect(flowThreadPortionRectAt(columnIndex));

flowThread->flipForWritingMode(portionRect);

- portionRect.moveBy(flowThread->topLeftLocation());

+ portionRect.moveBy(flowThread->physicalLocation());

LayoutRect columnRect(columnRectAt(columnIndex));

columnRect.move(offsetFromColumnSet());

m_columnSet.flipForWritingMode(columnRect);

- columnRect.moveBy(m_columnSet.topLeftLocation());

+ columnRect.moveBy(m_columnSet.physicalLocation());

LayoutSize translationRelativeToFlowThread =

columnRect.location() - portionRect.location();