Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2536453002: Rename some functions about layout locations (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
index 74bae4548d574c54e93fd836044f0d74cf80b4ab..ecaba8e7ce1d082500676a81876b682057d4ad78 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
@@ -852,11 +852,11 @@ static void deriveBorderBoxFromContainerContext(
(!boxModelObject.isSVG() || boxModelObject.isSVGRoot() ||
boxModelObject.isSVGForeignObject())) {
// TODO(pdr): Several calls in this function walk back up the tree to
- // calculate containers (e.g., topLeftLocation, offsetForInFlowPosition*).
+ // calculate containers (e.g., physicalLocation, offsetForInFlowPosition*).
// The containing block and other containers can be stored on
// PaintPropertyTreeBuilderContext instead of recomputing them.
context.current.paintOffset.moveBy(
- toLayoutBox(boxModelObject).topLeftLocation());
+ toLayoutBox(boxModelObject).physicalLocation());
// This is a weird quirk that table cells paint as children of table rows,
// but their location have the row's location baked-in.
// Similar adjustment is done in LayoutTableCell::offsetFromContainer().
@@ -864,7 +864,7 @@ static void deriveBorderBoxFromContainerContext(
LayoutObject* parentRow = boxModelObject.parent();
DCHECK(parentRow && parentRow->isTableRow());
context.current.paintOffset.moveBy(
- -toLayoutBox(parentRow)->topLeftLocation());
+ -toLayoutBox(parentRow)->physicalLocation());
}
}
}
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698