Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: third_party/WebKit/Source/core/paint/EllipsisBoxPainter.cpp

Issue 2536453002: Rename some functions about layout locations (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/EllipsisBoxPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/EllipsisBoxPainter.cpp b/third_party/WebKit/Source/core/paint/EllipsisBoxPainter.cpp
index 28aa709df01e5335825544505bf5728f406cd49b..263a20227e992807494d654f871063de4505965b 100644
--- a/third_party/WebKit/Source/core/paint/EllipsisBoxPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/EllipsisBoxPainter.cpp
@@ -33,9 +33,9 @@ void EllipsisBoxPainter::paintEllipsis(const PaintInfo& paintInfo,
LayoutUnit lineTop,
LayoutUnit lineBottom,
const ComputedStyle& style) {
- LayoutRect paintRect(m_ellipsisBox.logicalFrameRect());
- m_ellipsisBox.logicalRectToPhysicalRect(paintRect);
- paintRect.moveBy(paintOffset);
+ LayoutPoint boxOrigin = m_ellipsisBox.physicalLocation();
+ boxOrigin.moveBy(paintOffset);
+ LayoutRect paintRect(boxOrigin, m_ellipsisBox.size());
GraphicsContext& context = paintInfo.context;
DisplayItem::Type displayItemType =
@@ -47,8 +47,6 @@ void EllipsisBoxPainter::paintEllipsis(const PaintInfo& paintInfo,
DrawingRecorder recorder(context, m_ellipsisBox, displayItemType,
FloatRect(paintRect));
- LayoutPoint boxOrigin = m_ellipsisBox.locationIncludingFlipping();
- boxOrigin.moveBy(paintOffset);
LayoutRect boxRect(boxOrigin,
LayoutSize(m_ellipsisBox.logicalWidth(),
m_ellipsisBox.virtualLogicalHeight()));

Powered by Google App Engine
This is Rietveld 408576698