third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp - Issue 2536453002: Rename some functions about layout locations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

Issue 2536453002: Rename some functions about layout locations (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

index 4de3f2b63023260a6f399e8c966b70934080ebdd..e71d430f8282730ba003d72e1876662196616c5b 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

+++ b/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

@@ -411,7 +411,7 @@ bool InlineTextBox::nodeAtPoint(HitTestResult& result,

if (isLineBreak() || m_truncation == cFullTruncation)

return false;

- LayoutPoint boxOrigin = locationIncludingFlipping();

+ LayoutPoint boxOrigin = physicalLocation();

boxOrigin.moveBy(accumulatedOffset);

LayoutRect rect(boxOrigin, size());

if (visibleToHitTestRequest(result.hitTestRequest()) &&