third_party/WebKit/Source/core/layout/line/InlineFlowBox.h - Issue 2536453002: Rename some functions about layout locations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

Issue 2536453002: Rename some functions about layout locations (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

index 0589ef350c6bcf34c097bb0e2c750d4ebca93750..3c657572fc7ad4fa1485da06903b32a61a9e1cc7 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

+++ b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

@@ -356,8 +356,8 @@ class InlineFlowBox : public InlineBox {

LayoutRect frameRectIncludingLineHeight(LayoutUnit lineTop,

LayoutUnit lineBottom) const {

if (isHorizontal())

- return LayoutRect(m_topLeft.x(), lineTop, width(), lineBottom - lineTop);

- return LayoutRect(lineTop, m_topLeft.y(), lineBottom - lineTop, height());

+ return LayoutRect(x(), lineTop, logicalWidth(), lineBottom - lineTop);

+ return LayoutRect(lineTop, y(), lineBottom - lineTop, logicalWidth());

}

LayoutRect logicalFrameRectIncludingLineHeight(LayoutUnit lineTop,