Rename some functions about layout locations

third_party/WebKit/Source/core/layout/line/InlineBoxTest.cpp

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/layout/line/InlineBox.h"
+
+#include "core/layout/LayoutBlockFlow.h"
+#include "core/layout/LayoutTestHelper.h"
+
+namespace blink {
+
+using InlineBoxTest = RenderingTest;
+
+TEST_F(InlineBoxTest, LogicalRectToPhysicalRectNormal) {
+  setBodyInnerHTML(
+      "<div id='div' style='width: 80px; height: 50px'>Test</div>");
+  LayoutBlockFlow* div = toLayoutBlockFlow(getLayoutObjectByElementId("div"));
+  InlineBox* inlineBox = div->firstLineBox();
+  LayoutRect rect(11, 22, 33, 44);
+  inlineBox->logicalRectToPhysicalRect(rect);
+  EXPECT_EQ(LayoutRect(11, 22, 33, 44), rect);
+}
+
+TEST_F(InlineBoxTest, LogicalRectToPhysicalRectVerticalRL) {
+  setBodyInnerHTML(
+      "<div id='div' "
+      "style='writing-mode:vertical-rl; width: 80px; height: 50px'>Test</div>");
+  LayoutBlockFlow* div = toLayoutBlockFlow(getLayoutObjectByElementId("div"));
+  InlineBox* inlineBox = div->firstLineBox();
+  LayoutRect rect(11, 22, 33, 44);
+  inlineBox->logicalRectToPhysicalRect(rect);
+  EXPECT_EQ(LayoutRect(14, 11, 44, 33), rect);

[chrishtr, 2016/11/28 19:16:01]

Could you confirm quickly that this did not change with your patch?

[Xianzhu, 2016/11/28 20:10:07]

Confirmed that these tests passed without the change. I guess that you added
logicalPositionToPhysicalPoint(LayoutPoint, LayoutSize) because
flipForWritingMode(LayoutPoint) didn't work for you. With this change we use
flipForWritingMode(LayoutRect) for the purpose.

+}
+
+TEST_F(InlineBoxTest, LogicalRectToPhysicalRectVerticalLR) {
+  setBodyInnerHTML(
+      "<div id='div' "
+      "style='writing-mode:vertical-lr; width: 80px; height: 50px'>Test</div>");
+  LayoutBlockFlow* div = toLayoutBlockFlow(getLayoutObjectByElementId("div"));
+  InlineBox* inlineBox = div->firstLineBox();
+  LayoutRect rect(11, 22, 33, 44);
+  inlineBox->logicalRectToPhysicalRect(rect);
+  EXPECT_EQ(LayoutRect(22, 11, 44, 33), rect);

[chrishtr, 2016/11/28 19:16:01]

Same here. Just a little paranoid because I tried last year to do something
similar to this change and it didn't
work.

+}
+
+}  // namespace blink