Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2536443002: Reland "Only promote opaque scrollers which are stacking contexts." (Closed)

Created:
4 years ago by flackr
Modified:
4 years ago
Reviewers:
pdr, schenney
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Reland "Only promote opaque scrollers which are stacking contexts." Relanding https://codereview.chromium.org/2509203002/. Originally failed the svg/as-background-image/svg-width-100p-as-background.html test on android, this time removing the custom expectation for android. TBR=schenney, pdr BUG=666147 TEST=PaintLayerScrollableAreaTest.NonContainedLayersNotPromoted CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2522043002 Cr-Commit-Position: refs/heads/master@{#434201} (cherry picked from commit 79b54819da38f8047e234a647e21998e09b75e5f) Committed: https://chromium.googlesource.com/chromium/src/+/56f7c1e4c916655dbab30a49c1cea63b89d3f248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -136 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/scroll-partial-update-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-background-opaque-to-transparent.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-background-transparent-to-opaque.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/flexbox/scrollbars-changed-expected.txt View 3 chunks +9 lines, -59 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/repaint-composited-child-in-scrolled-container-expected.txt View 2 chunks +12 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/overflow/007-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-float-stacking-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-stacking-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/overflow/007-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/deprecated-flexbox/009-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/deprecated-flexbox/009-horizontal-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/003-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/007-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/overflow-float-stacking-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/overflow-rtl-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/overflow-rtl-vertical-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/overflow-stacking-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/overflow-with-local-background-attachment-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/repaint-composited-child-in-scrolled-container-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/deprecated-flexbox/009-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/deprecated-flexbox/009-horizontal-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/overflow/003-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/overflow/007-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-float-stacking-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-rtl-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-rtl-vertical-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-stacking-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/repaint-composited-child-in-scrolled-container-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/overflow/007-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-float-stacking-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-stacking-expected.png View Binary file 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp View 7 chunks +39 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
flackr
4 years ago (2016-11-25 22:52:22 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
56f7c1e4c916655dbab30a49c1cea63b89d3f248.

Powered by Google App Engine
This is Rietveld 408576698