Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2536423002: Quick View: Show geography metadata. (Closed)

Created:
4 years ago by oka
Modified:
4 years ago
Reviewers:
fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quick View: Show geography metadata. BUG=636191 TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/aa1f3ffb41d9126702b3295813c07da5b78e8488 Cr-Commit-Position: refs/heads/master@{#435238}

Patch Set 1 #

Patch Set 2 : Updated comments #

Patch Set 3 : Removed unneeded i18n entry. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_metadata_box.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_metadata_box.js View 1 1 chunk +32 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2532003005 Patch 120001

Dependent Patchsets:

Issue 2540863004 Patch 1
Issue 2540863004 Patch 20001
Issue 2540863004 Patch 40001

Messages

Total messages: 10 (5 generated)
oka
PTAL.
4 years ago (2016-11-30 08:42:01 UTC) #3
fukino
lgtm
4 years ago (2016-11-30 12:32:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536423002/40001
4 years ago (2016-11-30 12:38:14 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-30 13:23:27 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-30 13:25:13 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/aa1f3ffb41d9126702b3295813c07da5b78e8488
Cr-Commit-Position: refs/heads/master@{#435238}

Powered by Google App Engine
This is Rietveld 408576698