Added UMA counters for Android tool-types.

Added UMA counters for Android tool-types.

BUG=668248
Committed: https://crrev.com/097c9551cffc40afcb8a4cbd78d06f6523f412d6
Cr-Commit-Position: refs/heads/master@{#436069}

[mustaq, 2016-11-30 16:15:33]

mustaq@chromium.org changed reviewers:
+ dtapuska@chromium.org

[mustaq, 2016-11-30 16:15:33]

ptal

[dtapuska, 2016-12-01 20:31:34]

lgtm % nit

https://codereview.chromium.org/2536413003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2536413003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:93972: +  <int value="3"
label="Mouse">The tool is a mouse or trackpad.</int>
You need the eraser type here too

[mustaq, 2016-12-01 21:19:19]

https://codereview.chromium.org/2536413003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2536413003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:93972: +  <int value="3"
label="Mouse">The tool is a mouse or trackpad.</int>
On 2016/12/01 20:31:34, dtapuska wrote:
> You need the eraser type here too

Done.

[mustaq, 2016-12-01 21:31:31]

mustaq@chromium.org changed reviewers:
+ rkaplow@chromium.org, skyostil@chromium.org

[mustaq, 2016-12-01 21:31:32]

skyostil@chromium.org: Please review changes in content/browser/android.

rkaplow@chromium.org: Please review changes in tools/metrics/histograms.

[Sami, 2016-12-02 11:38:05]

content/browser/android/content_view_core_impl.cc lgtm.

[rkaplow, 2016-12-02 20:19:06]

https://codereview.chromium.org/2536413003/diff/20001/content/browser/android...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/2536413003/diff/20001/content/browser/android...
content/browser/android/content_view_core_impl.cc:171:
MotionEventAndroid::TOOL_TYPE_ERASER + 1);
instead of tool_type_eraser, you should have a TOOL_TYPE_MAX in the enum.
Otherwise if you add to the enum this will be wrong

https://codereview.chromium.org/2536413003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2536413003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:13525: +    touch, mouse or stylus).
nit, you say touch here and finger later. I'd be consistant

[rkaplow, 2016-12-02 20:19:37]

lgtm

lg with those fixes

[mustaq, 2016-12-02 20:37:17]

https://codereview.chromium.org/2536413003/diff/20001/content/browser/android...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/2536413003/diff/20001/content/browser/android...
content/browser/android/content_view_core_impl.cc:171:
MotionEventAndroid::TOOL_TYPE_ERASER + 1);
On 2016/12/02 20:19:06, rkaplow wrote:
> instead of tool_type_eraser, you should have a TOOL_TYPE_MAX in the enum.
> Otherwise if you add to the enum this will be wrong

Done.

https://codereview.chromium.org/2536413003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2536413003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:13525: +    touch, mouse or stylus).
On 2016/12/02 20:19:06, rkaplow wrote:
> nit, you say touch here and finger later. I'd be consistant

Done.

[mustaq, 2016-12-02 20:39:03]

mustaq@chromium.org changed reviewers:
+ tdresser@chromium.org

[mustaq, 2016-12-02 20:39:03]

tdresser@chromium.org: Please review changes in motion_event.h

[mustaq, 2016-12-02 21:10:47]

mustaq@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2016-12-02 21:11:05]

lgtm

[mustaq, 2016-12-02 21:12:37]

The CQ bit was checked by mustaq@chromium.org

[mustaq, 2016-12-02 21:12:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org, rkaplow@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2536413003/#ps40001
(title: "Add MotionEvent.TOOL_TYPE_LAST etc.")

[commit-bot: I haz the power, 2016-12-02 21:13:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 23:07:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480713157857200,
"parent_rev": "77307e9ac0b91d69e5431d27e4e618cce06c6855", "commit_rev":
"aa9d2bdde4bfd57936cb6d5c5208d206a7c7556e"}

[commit-bot: I haz the power, 2016-12-02 23:07:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-02 23:10:45]

Description was changed from

==========
Added UMA counters for Android tool-types.

BUG=668248
==========

to

==========
Added UMA counters for Android tool-types.

BUG=668248

Committed: https://crrev.com/097c9551cffc40afcb8a4cbd78d06f6523f412d6
Cr-Commit-Position: refs/heads/master@{#436069}
==========

[commit-bot: I haz the power, 2016-12-02 23:10:46]

Patchset 3 (id:??) landed as
https://crrev.com/097c9551cffc40afcb8a4cbd78d06f6523f412d6
Cr-Commit-Position: refs/heads/master@{#436069}