Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2536413002: Fix an exception in BatterMonitorFactory (Closed)

Created:
4 years ago by Jinsuk Kim
Modified:
4 years ago
Reviewers:
timvolodine
CC:
chromium-reviews, timvolodine, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an exception in BatterMonitorFactory Use a copy of the set to avoid ConcurrentModificationException. BUG=669294 Committed: https://crrev.com/e4c28faf93413833defafbc736a380d4c41b4a1b Cr-Commit-Position: refs/heads/master@{#435467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorFactory.java View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Jinsuk Kim
4 years ago (2016-11-30 07:29:17 UTC) #2
timvolodine
lgtm, any ideas why this happens? is this because of reentrancy and unsubscribe() can be ...
4 years ago (2016-11-30 13:31:02 UTC) #3
Jinsuk Kim
On 2016/11/30 13:31:02, timvolodine wrote: > lgtm, > any ideas why this happens? is this ...
4 years ago (2016-11-30 22:43:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536413002/1
4 years ago (2016-11-30 22:43:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 23:19:25 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-30 23:22:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4c28faf93413833defafbc736a380d4c41b4a1b
Cr-Commit-Position: refs/heads/master@{#435467}

Powered by Google App Engine
This is Rietveld 408576698