tools/clang/blink_gc_plugin/RecordInfo.cpp - Issue 2536403002: blink_gc_plugin should require tracing for classes that have a trace method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/RecordInfo.cpp

Issue 2536403002: blink_gc_plugin should require tracing for classes that have a trace method

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/blink_gc_plugin/RecordInfo.cpp

diff --git a/tools/clang/blink_gc_plugin/RecordInfo.cpp b/tools/clang/blink_gc_plugin/RecordInfo.cpp

index 46b8606a344d06d92c71eafd0cc3c2c5608021da..63967cdcee45b056f410eae5fc276146aaac5fdc 100644

--- a/tools/clang/blink_gc_plugin/RecordInfo.cpp

+++ b/tools/clang/blink_gc_plugin/RecordInfo.cpp

@@ -287,7 +287,7 @@ bool RecordInfo::RequiresTraceMethod() {

if (bases_with_trace > 1)

return true;

GetFields();

- return fields_need_tracing_.IsNeeded();

+ return fields_need_tracing_.IsNeeded() || GetTraceMethod();

}

// Get the actual tracing method (ie, can be traceAfterDispatch if there is a