Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(80)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: tools/clang/blink_gc_plugin/tests/base_with_trace_requires_tracing.txt
Issue
2536403002
:
blink_gc_plugin should require tracing for classes that have a trace method
Patch Set:
Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/Source/core/events/EventTarget.h
tools/clang/blink_gc_plugin/RecordInfo.cpp
tools/clang/blink_gc_plugin/tests/base_with_trace_requires_tracing.h
tools/clang/blink_gc_plugin/tests/base_with_trace_requires_tracing.cpp
tools/clang/blink_gc_plugin/tests/base_with_trace_requires_tracing.txt
View unified diff
|
Download patch
« no previous file with comments
|
« tools/clang/blink_gc_plugin/tests/base_with_trace_requires_tracing.cpp
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
base_with_trace_requires_tracing.cpp:16:1: warning: [blink-gc] Base class 'B' of derived class 'C' requires tracing.
2
void C::trace(Visitor* visitor) {
3
^
4
1 warning generated.
OLD
NEW
« no previous file with comments
|
« tools/clang/blink_gc_plugin/tests/base_with_trace_requires_tracing.cpp
('k') |
no next file »
|
no next file with comments »
Issue 2536403002: blink_gc_plugin should require tracing for classes that have a trace method
Created 4 years ago by keishi
Modified 4 years ago
Reviewers: haraken, oilpan-reviews, sof
Base URL:
Comments: 0
This is Rietveld
408576698