Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2536373008: Transition analyzer and analysis_server to new astFactory. (Closed)

Created:
4 years ago by Paul Berry
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Transition analyzer and analysis_server to new astFactory. This is the same as 1d028eed8dfa00ac9d4ff685e61b01e6909dbeb4 (which was reverted) except that it doesn't remove the old AST factory constructors (which broke dev_compiler). The removal of old AST factory constructors will be done in a follow-up CL so that if it unexpectedly breaks any other clients we will be able to revert it without reverting this CL. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/0c31815f1ce35eb03570cc1a0d5d571382b61519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1098 lines, -969 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 107 chunks +371 lines, -343 lines 0 comments Download
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 178 chunks +320 lines, -286 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_test_factory.dart View 69 chunks +170 lines, -156 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer/test/dart/ast/ast_test.dart View 31 chunks +110 lines, -71 lines 0 comments Download
M pkg/analyzer/test/dart/element/builder_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/element_resolver_test.dart View 4 chunks +7 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 15 chunks +38 lines, -25 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 24 chunks +28 lines, -47 lines 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 16 chunks +20 lines, -19 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/utilities_test.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years ago (2016-12-01 18:48:00 UTC) #2
scheglov
LGTM
4 years ago (2016-12-01 18:48:37 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 0c31815f1ce35eb03570cc1a0d5d571382b61519 (presubmit successful).
4 years ago (2016-12-01 18:56:28 UTC) #5
Brian Wilkerson
4 years ago (2016-12-01 19:05:42 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698