Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2784)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

Issue 2536373006: Instant apps: cleanup an unused parameter. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
index cbd3c4092e0708ebae489f4b1c71511d03223f26..123aac0177b707559eecb4f7502bd2e3cdcda94f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
@@ -551,10 +551,8 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat
}
@Override
- public boolean isSerpReferrer(String referrerUrl, Tab tab) {
- if (tab == null || tab.getWebContents() == null) {
- return false;
- }
+ public boolean isSerpReferrer(Tab tab) {
+ if (tab == null || tab.getWebContents() == null) return false;
NavigationController nController = tab.getWebContents().getNavigationController();
int index = nController.getLastCommittedEntryIndex();
@@ -584,7 +582,7 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat
ChromeLauncherActivity.isCustomTabIntent(resolvedIntent));
} else if (!isIncomingRedirect) {
// Check if the navigation is coming from SERP and skip instant app handling.
- if (isSerpReferrer(referrerUrl, tab)) return false;
+ if (isSerpReferrer(tab)) return false;
return handler.handleNavigation(
getAvailableContext(), url,
TextUtils.isEmpty(referrerUrl) ? null : Uri.parse(referrerUrl),

Powered by Google App Engine
This is Rietveld 408576698