Add --test-jar arg to test_runner to explicitly specify its path.

Add --test-jar arg to test_runner to explicitly specify its path.

Committed: https://crrev.com/4a1ddc199e19988c803fa8d85f1f26b929e390bf
Cr-Commit-Position: refs/heads/master@{#435444}

[mikecase (-- gone --), 2016-11-30 20:17:43]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org

[mikecase (-- gone --), 2016-11-30 20:17:46]

We discussed doing something like this yesterday (to make my --no-jar CL nicer).
How does this look?

[jbudorick, 2016-11-30 20:58:53]

https://codereview.chromium.org/2536373005/diff/20001/build/android/pylib/ins...
File build/android/pylib/instrumentation/instrumentation_test_instance.py
(right):

https://codereview.chromium.org/2536373005/diff/20001/build/android/pylib/ins...
build/android/pylib/instrumentation/instrumentation_test_instance.py:491:
self._test_support_apk = apk_helper.ToHelper(os.path.join(
I think we can just drop this, though we shouldn't do so in this CL.

https://codereview.chromium.org/2536373005/diff/20001/build/android/pylib/ins...
build/android/pylib/instrumentation/instrumentation_test_instance.py:497: if not
self._test_jar or not os.path.exists(self._test_jar):
This means that --test-jar is a required argument. Are you planning on changing
this in the CTS CL?

https://codereview.chromium.org/2536373005/diff/20001/build/android/test_runn...
File build/android/test_runner.py (right):

https://codereview.chromium.org/2536373005/diff/20001/build/android/test_runn...
build/android/test_runner.py:349: group.add_argument('--test-jar',
(if this is going to be required, it should be marked as such here)

[mikecase (-- gone --), 2016-11-30 21:05:09]

https://codereview.chromium.org/2536373005/diff/20001/build/android/pylib/ins...
File build/android/pylib/instrumentation/instrumentation_test_instance.py
(right):

https://codereview.chromium.org/2536373005/diff/20001/build/android/pylib/ins...
build/android/pylib/instrumentation/instrumentation_test_instance.py:497: if not
self._test_jar or not os.path.exists(self._test_jar):
On 2016/11/30 at 20:58:53, jbudorick wrote:
> This means that --test-jar is a required argument. Are you planning on
changing this in the CTS CL?

yes

https://codereview.chromium.org/2536373005/diff/20001/build/android/test_runn...
File build/android/test_runner.py (right):

https://codereview.chromium.org/2536373005/diff/20001/build/android/test_runn...
build/android/test_runner.py:349: group.add_argument('--test-jar',
On 2016/11/30 at 20:58:53, jbudorick wrote:
> (if this is going to be required, it should be marked as such here)

It will only be required until CTS CL lands. But, I can mark it as required for
the time being.
Added required=True which will be removed in future CL.

[jbudorick, 2016-11-30 21:08:18]

lgtm

https://codereview.chromium.org/2536373005/diff/20001/build/android/test_runn...
File build/android/test_runner.py (right):

https://codereview.chromium.org/2536373005/diff/20001/build/android/test_runn...
build/android/test_runner.py:349: group.add_argument('--test-jar',
On 2016/11/30 21:05:09, mikecase wrote:
> On 2016/11/30 at 20:58:53, jbudorick wrote:
> > (if this is going to be required, it should be marked as such here)
> 
> It will only be required until CTS CL lands. But, I can mark it as required
for
> the time being.
> Added required=True which will be removed in future CL.

ack. With you changing it in the CTS CL, this would be fine with me either way.

[mikecase (-- gone --), 2016-11-30 21:18:28]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2016-11-30 21:18:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 22:20:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480540708736300,
"parent_rev": "9137ae77fc15c3b5060b4455b39c371d6169dc66", "commit_rev":
"235711bd070d22eb737b70e58bdaee3a5c759320"}

[commit-bot: I haz the power, 2016-11-30 22:20:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-30 22:25:24]

Description was changed from

==========
Add --test-jar arg to test_runner to explicitly specify its path.
==========

to

==========
Add --test-jar arg to test_runner to explicitly specify its path.

Committed: https://crrev.com/4a1ddc199e19988c803fa8d85f1f26b929e390bf
Cr-Commit-Position: refs/heads/master@{#435444}
==========

[commit-bot: I haz the power, 2016-11-30 22:25:25]

Patchset 3 (id:??) landed as
https://crrev.com/4a1ddc199e19988c803fa8d85f1f26b929e390bf
Cr-Commit-Position: refs/heads/master@{#435444}