Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2536353003: [turbofan] fixed uninhabited type handling in ObjectState representation selection (Closed)

Created:
4 years ago by Tobias Tebbi
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] fixed uninhabited type handling in ObjectState representation selection R=jarin@chromium.org BUG=v8:668517 Committed: https://crrev.com/9b20a7b7a3b85ec0fc009e9bb9fc209f40426290 Cr-Commit-Position: refs/heads/master@{#41399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Tobias Tebbi
4 years ago (2016-11-30 17:03:48 UTC) #1
Jarin
lgtm, thanks for fixing!
4 years ago (2016-11-30 19:59:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536353003/1
4 years ago (2016-11-30 21:19:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 21:45:46 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-30 21:46:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b20a7b7a3b85ec0fc009e9bb9fc209f40426290
Cr-Commit-Position: refs/heads/master@{#41399}

Powered by Google App Engine
This is Rietveld 408576698