[Findit] Support gtest on Android.

[Findit] Support gtest on Android.

BUG=669203
R=chanli, lijeffrey

Committed: https://chromium.googlesource.com/infra/infra/+/f2fc5838a4b645a8cfb5cb88264b41b42fd056b9

[stgao, 2016-11-29 21:19:34]

Patchset #1 (id:1) has been deleted

[stgao, 2016-11-29 21:19:49]

ptal, tiny change.

[chanli, 2016-11-29 23:11:49]

LGTM with a nit and a question.

https://codereview.chromium.org/2536313002/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py (right):

https://codereview.chromium.org/2536313002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py:50: # On
Android, this is only supported for gtest, but not for other test
Nit: 'this' is a little ambiguous here, maybe change it to 'gtest_repeat' flag
explicitly?

https://codereview.chromium.org/2536313002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py:79: # exists.
Question: If this flag is not supported on Android, will an error happen or this
flag will be simply ignored?

[stgao, 2016-11-30 00:26:27]

https://codereview.chromium.org/2536313002/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py (right):

https://codereview.chromium.org/2536313002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py:50: # On
Android, this is only supported for gtest, but not for other test
On 2016/11/29 23:11:49, chanli wrote:
> Nit: 'this' is a little ambiguous here, maybe change it to 'gtest_repeat' flag
> explicitly?

Good catch. Done.

https://codereview.chromium.org/2536313002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py:79: # exists.
On 2016/11/29 23:11:49, chanli wrote:
> Question: If this flag is not supported on Android, will an error happen or
this
> flag will be simply ignored?

Ignored. Comments updated.

[stgao, 2016-11-30 00:26:30]

The CQ bit was checked by stgao@chromium.org

[stgao, 2016-11-30 00:26:30]

The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org
Link to the patchset: https://codereview.chromium.org/2536313002/#ps40001
(title: "Update comments.")

[commit-bot: I haz the power, 2016-11-30 00:26:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 00:41:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480465590536810,
"parent_rev": "6131c01bfda2e0ed621cc8a23347a245896cc91b", "commit_rev":
"f2fc5838a4b645a8cfb5cb88264b41b42fd056b9"}

[commit-bot: I haz the power, 2016-11-30 00:42:01]

Description was changed from

==========
[Findit] Support gtest on Android.

BUG=669203
R=chanli, lijeffrey
==========

to

==========
[Findit] Support gtest on Android.

BUG=669203
R=chanli, lijeffrey

Committed:
https://chromium.googlesource.com/infra/infra/+/f2fc5838a4b645a8cfb5cb88264b4...
==========

[commit-bot: I haz the power, 2016-11-30 00:42:02]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/f2fc5838a4b645a8cfb5cb88264b4...