Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 2536293002: Revert of Add a crash key to record whether a windows machine is domain joined. (Closed)

Created:
4 years ago by iclelland
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a crash key to record whether a windows machine is domain joined. (patchset #3 id:60001 of https://codereview.chromium.org/2514483002/ ) Reason for revert: Reverting this; it appears to be causing 140+ failures in telmetry tests on Win7 (See the failures in https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/55150/steps/telemetry_unittests%20on%20Windows-7-SP1/logs/stdio ) As far as I can tell (the log output is being suppressed,) it looks it's hitting the DCHECK in SetCrashKeyValue that would indicate that the key isn't registered as expected. Also filed https://bugs.chromium.org/p/chromium/issues/detail?id=669633 Original issue's description: > Add a crash key to record whether a windows machine is domain joined. > > BUG=660868 > > Committed: https://crrev.com/bf33256aee8db58c30b9d36e991055f2a4ed62a4 > Cr-Commit-Position: refs/heads/master@{#435018} TBR=siggi@chromium.org,sky@chromium.org,georgesak@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=660868 Committed: https://crrev.com/a185fbad8292f03144c35895c04db3fbe63c43a9 Cr-Commit-Position: refs/heads/master@{#435069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M chrome/browser/chrome_browser_main.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/common/crash_keys.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/crash_keys.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
iclelland
Created Revert of Add a crash key to record whether a windows machine is domain ...
4 years ago (2016-11-29 20:25:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536293002/1
4 years ago (2016-11-29 20:26:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 20:27:25 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-29 20:32:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a185fbad8292f03144c35895c04db3fbe63c43a9
Cr-Commit-Position: refs/heads/master@{#435069}

Powered by Google App Engine
This is Rietveld 408576698