Chromium Code Reviews
DescriptionRevert of Add a crash key to record whether a windows machine is domain joined. (patchset #3 id:60001 of https://codereview.chromium.org/2514483002/ )
Reason for revert:
Reverting this; it appears to be causing 140+ failures in telmetry tests on Win7 (See the failures in https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/55150/steps/telemetry_unittests%20on%20Windows-7-SP1/logs/stdio )
As far as I can tell (the log output is being suppressed,) it looks it's hitting the DCHECK in SetCrashKeyValue that would indicate that the key isn't registered as expected.
Also filed https://bugs.chromium.org/p/chromium/issues/detail?id=669633
Original issue's description:
> Add a crash key to record whether a windows machine is domain joined.
>
> BUG=660868
>
> Committed: https://crrev.com/bf33256aee8db58c30b9d36e991055f2a4ed62a4
> Cr-Commit-Position: refs/heads/master@{#435018}
TBR=siggi@chromium.org,sky@chromium.org,georgesak@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=660868
Committed: https://crrev.com/a185fbad8292f03144c35895c04db3fbe63c43a9
Cr-Commit-Position: refs/heads/master@{#435069}
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|
|||||||||||||||||||||||||||||||||||||