Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2536273003: [DevTools] Remove Workspace.projectTypes enum part1. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove Workspace.projectTypes enum part1. This enum is a layering violation and blocks further improvements in workspace area. The patch does not remove the enum entirely yet, but fixes most of the usages by introducing domain-specific helper methods. BUG=none

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -153 lines) Patch
M third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 chunk +20 lines, -33 lines 6 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js View 5 chunks +8 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js View 2 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 7 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js View 10 chunks +15 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js View 8 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 5 chunks +6 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/WorkspaceMappingTip.js View 2 chunks +13 lines, -23 lines 0 comments Download

Depends on Patchset:

Issue 2540803003 Patch 1

Dependent Patchsets:

Issue 2537223003 Patch 1

Messages

Total messages: 7 (5 generated)
dgozman
Take a look please.
4 years ago (2016-11-30 01:56:14 UTC) #6
lushnikov
4 years ago (2016-11-30 02:51:36 UTC) #7 
lgtm

https://codereview.chromium.org/2536273003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2536273003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:743:
contextMenu.appendItem(Common.UIString('Save'), () => {
Save as...

https://codereview.chromium.org/2536273003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:744:
contentProvider.requestContent().then((content) => {
let's pull this out as a function

https://codereview.chromium.org/2536273003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:753: var
uiSourceCode = /** @type {!Workspace.UISourceCode} */ (contentProvider);
let's assert!

https://codereview.chromium.org/2536273003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:754:
contextMenu.appendItem(UI.copyLinkAddressLabel(), () =>
InspectorFrontendHost.copyText(uiSourceCode.contentURL()));
move this and one below to the top

https://codereview.chromium.org/2536273003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:760:
uiSourceCode.commitWorkingCopy();
nit: oneliner possible

https://codereview.chromium.org/2536273003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:764:
uiSourceCode.saveAs();
nit: oneliner possible

Powered by Google App Engine
This is Rietveld 408576698