Consolidate AST element/type interfaces.

Consolidate AST element/type interfaces.

The AST getters/setters for `bestElement`, `propagatedElement`, and
`staticElement` having type `MethodElement` are moved to a common
interface class, `MethodReferenceExpression`.

The AST getters/setters for `staticElement` having type
`ConstructorElement` are moved to a common interface class,
`ConstructorReferenceNode`.

The overrides for `propagatedInvokeType` and `staticInvokeType` are
removed from `FunctionExpressionInvocation` and `MethodInvocation`,
since these overrides are identical to the corresponding declarations
in the base class, `InvocationExpression`.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/be11197a6ca272d30b3f8ecac83cc065fccdbd35

[Paul Berry, 2016-11-29 17:42:56]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-11-29 18:07:28]

lgtm

https://codereview.chromium.org/2536253002/diff/20001/pkg/analyzer/lib/dart/a...
File pkg/analyzer/lib/dart/ast/ast.dart (right):

https://codereview.chromium.org/2536253002/diff/20001/pkg/analyzer/lib/dart/a...
pkg/analyzer/lib/dart/ast/ast.dart:2404: * An AST node which makes reference to
a constructor.
"which" --> "that"

https://codereview.chromium.org/2536253002/diff/20001/pkg/analyzer/lib/dart/a...
pkg/analyzer/lib/dart/ast/ast.dart:5724: * An expression which implicity makes
reference to a method.
"which" --> "that"

[Paul Berry, 2016-11-29 18:11:03]

https://codereview.chromium.org/2536253002/diff/20001/pkg/analyzer/lib/dart/a...
File pkg/analyzer/lib/dart/ast/ast.dart (right):

https://codereview.chromium.org/2536253002/diff/20001/pkg/analyzer/lib/dart/a...
pkg/analyzer/lib/dart/ast/ast.dart:2404: * An AST node which makes reference to
a constructor.
On 2016/11/29 18:07:28, Brian Wilkerson wrote:
> "which" --> "that"

Done.

https://codereview.chromium.org/2536253002/diff/20001/pkg/analyzer/lib/dart/a...
pkg/analyzer/lib/dart/ast/ast.dart:5724: * An expression which implicity makes
reference to a method.
On 2016/11/29 18:07:28, Brian Wilkerson wrote:
> "which" --> "that"

Done.

[Paul Berry, 2016-11-29 18:11:41]

Description was changed from

==========
Consolidate AST element/type interfaces.

The AST getters/setters for `bestElement`, `propagatedElement`, and
`staticElement` having type `MethodElement` are moved to a common
interface class, `MethodReferenceExpression`.

The AST getters/setters for `staticElement` having type
`ConstructorElement` are moved to a common interface class,
`ConstructorReferenceNode`.

The overrides for `propagatedInvokeType` and `staticInvokeType` are
removed from `FunctionExpressionInvocation` and `MethodInvocation`,
since these overrides are identical to the corresponding declarations
in the base class, `InvocationExpression`.
==========

to

==========
Consolidate AST element/type interfaces.

The AST getters/setters for `bestElement`, `propagatedElement`, and
`staticElement` having type `MethodElement` are moved to a common
interface class, `MethodReferenceExpression`.

The AST getters/setters for `staticElement` having type
`ConstructorElement` are moved to a common interface class,
`ConstructorReferenceNode`.

The overrides for `propagatedInvokeType` and `staticInvokeType` are
removed from `FunctionExpressionInvocation` and `MethodInvocation`,
since these overrides are identical to the corresponding declarations
in the base class, `InvocationExpression`.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/be11197a6ca272d30b3f8ecac83cc065fccdbd35
==========

[Paul Berry, 2016-11-29 18:11:42]

Committed patchset #2 (id:20001) manually as
be11197a6ca272d30b3f8ecac83cc065fccdbd35 (presubmit successful).