Issue 253623002: Remove BitmapFetcher's dependency on Profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 253623002: Remove BitmapFetcher's dependency on Profile (Closed)

Created:
6 years, 8 months ago by noms (inactive)

Modified:
6 years, 8 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove BitmapFetcher's dependency on Profile BitmapFetcher just needs a RequestContext and not a whole profile. This is needed by https://codereview.chromium.org/222313005/, where we don't want to add an implicit Profile dependency to the ProfileInfoCache. BUG=305048 TEST=Existing tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266363

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -12 lines)			Patch
M	chrome/browser/android/banners/app_banner_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bitmap_fetcher.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/bitmap_fetcher.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/bitmap_fetcher_browsertest.cc	View	4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/notifications/sync_notifier/image_holder.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/notifications/sync_notifier/synced_notification.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/253623002/1

6 years, 8 months ago (2014-04-25 22:16:38 UTC) #5

Message was sent while issue was closed.

Change committed as 266363