Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

Issue 2536223003: Refactor ContentViewClient (3/6) (Closed)
Patch Set: removed getDesiredMeasureSpec Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
index eece558099fe9f62138d81f9ae6693246cc4dd01..5c2e0fc5391b78fa3ffb99c1a02b8571815ebb90 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
@@ -8,7 +8,6 @@ import android.content.ActivityNotFoundException;
import android.content.Context;
import android.content.Intent;
import android.view.KeyEvent;
-import android.view.View.MeasureSpec;
import org.chromium.base.Log;
import org.chromium.base.metrics.RecordUserAction;
@@ -24,40 +23,17 @@ import org.chromium.base.metrics.RecordUserAction;
* TODO(mkosiba): Rid this guy of default implementations. This class is used by both WebView and
* the browser and we don't want a the browser-specific default implementation to accidentally leak
* over to WebView.
+ *
+ * WARNING: ConteViewClient is going away. Do not add new stuff in this class.
*/
public class ContentViewClient {
// Tag used for logging.
private static final String TAG = "cr_ContentViewClient";
- // Default value to signal that the ContentView's size should not be overridden.
- private static final int UNSPECIFIED_MEASURE_SPEC =
- MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED);
-
private static final String GEO_SCHEME = "geo";
private static final String TEL_SCHEME = "tel";
private static final String MAILTO_SCHEME = "mailto";
- /**
- * Called whenever the background color of the page changes as notified by WebKit.
- * @param color The new ARGB color of the page background.
- */
- public void onBackgroundColorChanged(int color) {
- }
-
- /**
- * Notifies the client of the position of the top controls.
- * @param topControlsOffsetY The Y offset of the top controls in physical pixels.
- * @param topContentOffsetY The Y offset of the content in physical pixels.
- */
- public void onTopControlsChanged(float browserControlsOffsetY, float topContentOffsetY) {}
-
- /**
- * Notifies the client of the position of the bottom controls.
- * @param bottomControlsOffsetY The Y offset of the bottom controls in physical pixels.
- * @param bottomContentOffsetY The Y offset of the content in physical pixels.
- */
- public void onBottomControlsChanged(float bottomControlsOffsetY, float bottomContentOffsetY) { }
-
public boolean shouldOverrideKeyEvent(KeyEvent event) {
int keyCode = event.getKeyCode();
@@ -148,66 +124,4 @@ public class ContentViewClient {
}
return true;
}
-
- /**
- * ContentViewClient users can return a custom value to override the width of
- * the ContentView. By default, this method returns MeasureSpec.UNSPECIFIED, which
- * indicates that the value should not be overridden.
- *
- * @return The desired width of the ContentView.
- */
- public int getDesiredWidthMeasureSpec() {
- return UNSPECIFIED_MEASURE_SPEC;
- }
-
- /**
- * ContentViewClient users can return a custom value to override the height of
- * the ContentView. By default, this method returns MeasureSpec.UNSPECIFIED, which
- * indicates that the value should not be overridden.
- *
- * @return The desired height of the ContentView.
- */
- public int getDesiredHeightMeasureSpec() {
- return UNSPECIFIED_MEASURE_SPEC;
- }
-
- /**
- * Returns the left system window inset in pixels. The system window inset represents the area
- * of a full-screen window that is partially or fully obscured by the status bar, navigation
- * bar, IME or other system windows.
- * @return The left system window inset.
- */
- public int getSystemWindowInsetLeft() {
- return 0;
- }
-
- /**
- * Returns the top system window inset in pixels. The system window inset represents the area of
- * a full-screen window that is partially or fully obscured by the status bar, navigation bar,
- * IME or other system windows.
- * @return The top system window inset.
- */
- public int getSystemWindowInsetTop() {
- return 0;
- }
-
- /**
- * Returns the right system window inset in pixels. The system window inset represents the area
- * of a full-screen window that is partially or fully obscured by the status bar, navigation
- * bar, IME or other system windows.
- * @return The right system window inset.
- */
- public int getSystemWindowInsetRight() {
- return 0;
- }
-
- /**
- * Returns the bottom system window inset in pixels. The system window inset represents the area
- * of a full-screen window that is partially or fully obscured by the status bar, navigation
- * bar, IME or other system windows.
- * @return The bottom system window inset.
- */
- public int getSystemWindowInsetBottom() {
- return 0;
- }
}

Powered by Google App Engine
This is Rietveld 408576698