Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4118)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

Issue 2536223003: Refactor ContentViewClient (3/6) (Closed)
Patch Set: removed getDesiredMeasureSpec Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
index 0b6b6ad602070ee521e044da6fdb51c578b94a44..819ed9b32542f38266e0943051b83ab0e44aa58e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
@@ -53,7 +53,7 @@ import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.util.ColorUtils;
import org.chromium.chrome.browser.widget.ClipDrawableProgressBar.DrawingInfo;
import org.chromium.chrome.browser.widget.ControlContainer;
-import org.chromium.content.browser.ContentViewClient;
+import org.chromium.content.browser.ContentView;
import org.chromium.content.browser.ContentViewCore;
import org.chromium.content.browser.SPenSupport;
import org.chromium.ui.UiUtils;
@@ -909,30 +909,19 @@ public class CompositorViewHolder extends CoordinatorLayout
}
/**
- * Adjusts the physical backing size of a given ContentViewCore. This method will first check
- * if the ContentViewCore's client wants to override the size and, if so, it will use the
- * values provided by the {@link ContentViewClient#getDesiredWidthMeasureSpec()} and
- * {@link ContentViewClient#getDesiredHeightMeasureSpec()} methods. If no value is provided
- * in one of these methods, the values from the |width| and |height| arguments will be
- * used instead.
- *
+ * Adjusts the physical backing size of a given ContentViewCore. This method checks
+ * the associated container view to see if the size needs to be overriden, such as when used for
+ * {@link OverlayPanel}.
* @param contentViewCore The {@link ContentViewCore} to resize.
* @param width The default width.
* @param height The default height.
*/
private void adjustPhysicalBackingSize(ContentViewCore contentViewCore, int width, int height) {
- ContentViewClient client = contentViewCore.getContentViewClient();
-
- int desiredWidthMeasureSpec = client.getDesiredWidthMeasureSpec();
- if (MeasureSpec.getMode(desiredWidthMeasureSpec) != MeasureSpec.UNSPECIFIED) {
- width = MeasureSpec.getSize(desiredWidthMeasureSpec);
- }
-
- int desiredHeightMeasureSpec = client.getDesiredHeightMeasureSpec();
- if (MeasureSpec.getMode(desiredHeightMeasureSpec) != MeasureSpec.UNSPECIFIED) {
- height = MeasureSpec.getSize(desiredHeightMeasureSpec);
+ ContentView cv = (ContentView) contentViewCore.getContainerView();
+ if (cv.getDesiredWidth() != 0 && cv.getDesiredHeight() != 0) {
+ width = cv.getDesiredWidth();
+ height = cv.getDesiredHeight();
}
-
contentViewCore.onPhysicalBackingSizeChanged(width, height);
}

Powered by Google App Engine
This is Rietveld 408576698