Refactor ContentViewClient (3/6)

ui/android/view_android.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_ANDROID_VIEW_ANDROID_H_
 #define UI_ANDROID_VIEW_ANDROID_H_
 
 #include <list>
 
 #include "base/android/jni_weak_ref.h"
 #include "base/memory/ref_counted.h"
 #include "ui/android/ui_android_export.h"
 #include "ui/gfx/geometry/rect_f.h"
 
+typedef unsigned int SkColor;

[boliu, 2016/11/30 23:22:35]

include instead

[Jinsuk Kim, 2016/12/01 07:59:38]

I was a bit puzzled because #include "third_party/skia/include/core/SkColor.h"
doesn't work - compiler gave an error not finding other skia header. Then I saw
there are many other files do typedef like this for SkColor and just followed
them. Will take another look.

[boliu, 2016/12/01 23:57:52]

Yeah that's really odd. should figure out why include doesn't work

[Jinsuk Kim, 2016/12/02 03:52:07]

Turns out the error happened because device/power_save_blocker that includes
view_android.h has to have //skia, which was absent in its build gn. Fixed.

+
 namespace cc {
 class Layer;
 }
 
 namespace ui {
 
 class WindowAndroid;
 
 // A simple container for a UI layer.
 // At the root of the hierarchy is a WindowAndroid, when attached.
@@ skipping 47 matching lines @@
   void SetDelegate(const base::android::JavaRef<jobject>& delegate);
 
   // Adds this view as a child of another view.
   void AddChild(ViewAndroid* child);
 
   // Detaches this view from its parent.
   void RemoveFromParent();
 
   bool StartDragAndDrop(const base::android::JavaRef<jstring>& jtext,
                         const base::android::JavaRef<jobject>& jimage);
+  void OnBackgroundColorChanged(SkColor color);
 
   ScopedAnchorView AcquireAnchorView();
   void SetAnchorRect(const base::android::JavaRef<jobject>& anchor,
                      const gfx::RectF& bounds);
 
  protected:
   ViewAndroid* parent_;
 
  private:
   void RemoveChild(ViewAndroid* child);
 
   // Returns the Java delegate for this view. This is used to delegate work
   // up to the embedding view (or the embedder that can deal with the
   // implementation details).
   const base::android::ScopedJavaLocalRef<jobject>
       GetViewAndroidDelegate() const;
 
   std::list<ViewAndroid*> children_;
   scoped_refptr<cc::Layer> layer_;
   JavaObjectWeakGlobalRef delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(ViewAndroid);
 };
 
 }  // namespace ui
 
 #endif  // UI_ANDROID_VIEW_ANDROID_H_