chrome/browser/android/vr_shell/vr_shell.cc - Issue 2536223002: Omnibox improvements and fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/vr_shell.cc

Issue 2536223002: Omnibox improvements and fixes. (Closed)

Patch Set: Separate omnibox icon selection from webVR warning toggle. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/vr_shell/vr_shell.cc

diff --git a/chrome/browser/android/vr_shell/vr_shell.cc b/chrome/browser/android/vr_shell/vr_shell.cc

index 5c58081dcd53aee0a7ef018c996fff160a104ce2..f6833c77db94b60ae27dc1d2b248cb4cf1ead1aa 100644

--- a/chrome/browser/android/vr_shell/vr_shell.cc

+++ b/chrome/browser/android/vr_shell/vr_shell.cc

@@ -913,7 +913,8 @@ void VrShell::SetWebVrMode(JNIEnv* env,

}

void VrShell::SetWebVRSecureOrigin(bool secure_origin) {

- html_interface_->SetSecureOrigin(secure_origin);

+ // TODO(cjgrant): Align this state with the logic that drives the omnibox.

+ html_interface_->SetWebVRSecureOrigin(secure_origin);

}

void VrShell::SubmitWebVRFrame() {