|
|
Chromium Code Reviews|
Created:
4 years ago by Daniel Kurtz Modified:
4 years ago CC:
chromium-reviews Target Ref:
refs/pending/branch-heads/2924 Project:
chromium Visibility:
Public. |
Descriptionbase: Print sub-second resolution timestamps
Currently Chrome logs time in full seconds.
On Chrome OS, all other loggers use at least microsecond resolution.
This makes it hard to compare Chrome timestamps to other system events.
Instead, have Chrome use gettimeofday() on POSIX to fetch microsecond resolution timestamps, and GetLocalTime() on Windows to fetch millisecond resolution timestamps
Note: the Windows implementation is adapted from mini_chromium:
https://chromium.googlesource.com/chromium/mini_chromium/+/9f129335dbe57ae9a3...
BUG=chromium:638472
TEST=tail -F /var/log/chrome/chrome shows microsecond timestamps, like:
[1:1:1123/185804.213359:VERBOSE1:zygote_main_linux.cc(599)] ZygoteMain: initializing 2 fork delegates
R=dcheng
NOPRESUBMIT=true
NOTRY=true
TBR=mark
Review-Url: https://codereview.chromium.org/2528613002
Cr-Commit-Position: refs/heads/master@{#435254}
(cherry picked from commit 543a3be1be43bf23fbca2140ad90d18ee7ec6655)
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
The CQ bit was checked by djkurtz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== base: Print sub-second resolution timestamps Currently Chrome logs time in full seconds. On Chrome OS, all other loggers use at least microsecond resolution. This makes it hard to compare Chrome timestamps to other system events. Instead, have Chrome use gettimeofday() on POSIX to fetch microsecond resolution timestamps, and GetLocalTime() on Windows to fetch millisecond resolution timestamps Note: the Windows implementation is adapted from mini_chromium: https://chromium.googlesource.com/chromium/mini_chromium/+/9f129335dbe57ae9a3... BUG=chromium:638472 TEST=tail -F /var/log/chrome/chrome shows microsecond timestamps, like: [1:1:1123/185804.213359:VERBOSE1:zygote_main_linux.cc(599)] ZygoteMain: initializing 2 fork delegates R=dcheng NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2528613002 Cr-Commit-Position: refs/heads/master@{#435254} (cherry picked from commit 543a3be1be43bf23fbca2140ad90d18ee7ec6655) ========== to ========== base: Print sub-second resolution timestamps Currently Chrome logs time in full seconds. On Chrome OS, all other loggers use at least microsecond resolution. This makes it hard to compare Chrome timestamps to other system events. Instead, have Chrome use gettimeofday() on POSIX to fetch microsecond resolution timestamps, and GetLocalTime() on Windows to fetch millisecond resolution timestamps Note: the Windows implementation is adapted from mini_chromium: https://chromium.googlesource.com/chromium/mini_chromium/+/9f129335dbe57ae9a3... BUG=chromium:638472 TEST=tail -F /var/log/chrome/chrome shows microsecond timestamps, like: [1:1:1123/185804.213359:VERBOSE1:zygote_main_linux.cc(599)] ZygoteMain: initializing 2 fork delegates R=dcheng NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2528613002 Cr-Commit-Position: refs/heads/master@{#435254} (cherry picked from commit 543a3be1be43bf23fbca2140ad90d18ee7ec6655) ==========
djkurtz@chromium.org changed reviewers: + mark@chromium.org
Description was changed from ========== base: Print sub-second resolution timestamps Currently Chrome logs time in full seconds. On Chrome OS, all other loggers use at least microsecond resolution. This makes it hard to compare Chrome timestamps to other system events. Instead, have Chrome use gettimeofday() on POSIX to fetch microsecond resolution timestamps, and GetLocalTime() on Windows to fetch millisecond resolution timestamps Note: the Windows implementation is adapted from mini_chromium: https://chromium.googlesource.com/chromium/mini_chromium/+/9f129335dbe57ae9a3... BUG=chromium:638472 TEST=tail -F /var/log/chrome/chrome shows microsecond timestamps, like: [1:1:1123/185804.213359:VERBOSE1:zygote_main_linux.cc(599)] ZygoteMain: initializing 2 fork delegates R=dcheng NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2528613002 Cr-Commit-Position: refs/heads/master@{#435254} (cherry picked from commit 543a3be1be43bf23fbca2140ad90d18ee7ec6655) ========== to ========== base: Print sub-second resolution timestamps Currently Chrome logs time in full seconds. On Chrome OS, all other loggers use at least microsecond resolution. This makes it hard to compare Chrome timestamps to other system events. Instead, have Chrome use gettimeofday() on POSIX to fetch microsecond resolution timestamps, and GetLocalTime() on Windows to fetch millisecond resolution timestamps Note: the Windows implementation is adapted from mini_chromium: https://chromium.googlesource.com/chromium/mini_chromium/+/9f129335dbe57ae9a3... BUG=chromium:638472 TEST=tail -F /var/log/chrome/chrome shows microsecond timestamps, like: [1:1:1123/185804.213359:VERBOSE1:zygote_main_linux.cc(599)] ZygoteMain: initializing 2 fork delegates R=dcheng NOPRESUBMIT=true NOTRY=true TBR=mark Review-Url: https://codereview.chromium.org/2528613002 Cr-Commit-Position: refs/heads/master@{#435254} (cherry picked from commit 543a3be1be43bf23fbca2140ad90d18ee7ec6655) ==========
The CQ bit was checked by djkurtz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2016/12/02 05:31:23, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. Mark, can you help me land this patch on the branch?
On 2016/12/02 05:31:23, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. Mark, can you help me land this patch on the branch?
On 2016/12/02 05:31:23, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. Mark, can you help me land this patch on the branch?
LGTM
The CQ bit was checked by djkurtz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480730134583030, "parent_rev":
"ab373fbc21e491946a0b97e313bc151aabb60f7d", "commit_rev":
"7702c66a6cc89b820d4292d7bdaaac8cb0d1c3fd"}
Message was sent while issue was closed.
Description was changed from ========== base: Print sub-second resolution timestamps Currently Chrome logs time in full seconds. On Chrome OS, all other loggers use at least microsecond resolution. This makes it hard to compare Chrome timestamps to other system events. Instead, have Chrome use gettimeofday() on POSIX to fetch microsecond resolution timestamps, and GetLocalTime() on Windows to fetch millisecond resolution timestamps Note: the Windows implementation is adapted from mini_chromium: https://chromium.googlesource.com/chromium/mini_chromium/+/9f129335dbe57ae9a3... BUG=chromium:638472 TEST=tail -F /var/log/chrome/chrome shows microsecond timestamps, like: [1:1:1123/185804.213359:VERBOSE1:zygote_main_linux.cc(599)] ZygoteMain: initializing 2 fork delegates R=dcheng NOPRESUBMIT=true NOTRY=true TBR=mark Review-Url: https://codereview.chromium.org/2528613002 Cr-Commit-Position: refs/heads/master@{#435254} (cherry picked from commit 543a3be1be43bf23fbca2140ad90d18ee7ec6655) ========== to ========== base: Print sub-second resolution timestamps Currently Chrome logs time in full seconds. On Chrome OS, all other loggers use at least microsecond resolution. This makes it hard to compare Chrome timestamps to other system events. Instead, have Chrome use gettimeofday() on POSIX to fetch microsecond resolution timestamps, and GetLocalTime() on Windows to fetch millisecond resolution timestamps Note: the Windows implementation is adapted from mini_chromium: https://chromium.googlesource.com/chromium/mini_chromium/+/9f129335dbe57ae9a3... BUG=chromium:638472 TEST=tail -F /var/log/chrome/chrome shows microsecond timestamps, like: [1:1:1123/185804.213359:VERBOSE1:zygote_main_linux.cc(599)] ZygoteMain: initializing 2 fork delegates R=dcheng NOPRESUBMIT=true NOTRY=true TBR=mark Review-Url: https://codereview.chromium.org/2528613002 Cr-Commit-Position: refs/heads/master@{#435254} (cherry picked from commit 543a3be1be43bf23fbca2140ad90d18ee7ec6655) ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
