Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2536203005: base: Print sub-second resolution timestamps (Closed)

Created:
4 years ago by Daniel Kurtz
Modified:
4 years ago
Reviewers:
Mark Mentovai, dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

base: Print sub-second resolution timestamps Currently Chrome logs time in full seconds. On Chrome OS, all other loggers use at least microsecond resolution. This makes it hard to compare Chrome timestamps to other system events. Instead, have Chrome use gettimeofday() on POSIX to fetch microsecond resolution timestamps, and GetLocalTime() on Windows to fetch millisecond resolution timestamps Note: the Windows implementation is adapted from mini_chromium: https://chromium.googlesource.com/chromium/mini_chromium/+/9f129335dbe57ae9a3... BUG=chromium:638472 TEST=tail -F /var/log/chrome/chrome shows microsecond timestamps, like: [1:1:1123/185804.213359:VERBOSE1:zygote_main_linux.cc(599)] ZygoteMain: initializing 2 fork delegates R=dcheng NOPRESUBMIT=true NOTRY=true TBR=mark Review-Url: https://codereview.chromium.org/2528613002 Cr-Commit-Position: refs/heads/master@{#435254} (cherry picked from commit 543a3be1be43bf23fbca2140ad90d18ee7ec6655)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M base/logging.cc View 2 chunks +21 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536203005/1
4 years ago (2016-12-01 02:37:55 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-01 02:37:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536203005/1
4 years ago (2016-12-02 05:31:21 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-02 05:31:23 UTC) #11
Daniel Kurtz
On 2016/12/02 05:31:23, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years ago (2016-12-02 05:56:35 UTC) #12
Daniel Kurtz
On 2016/12/02 05:31:23, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years ago (2016-12-02 05:56:35 UTC) #13
Daniel Kurtz
On 2016/12/02 05:31:23, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years ago (2016-12-02 05:56:36 UTC) #14
Mark Mentovai
LGTM
4 years ago (2016-12-02 15:03:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536203005/1
4 years ago (2016-12-03 01:55:54 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-03 02:16:50 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698