Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2536163002: test_converter: Avoid conversion for gzipped SVGs (Closed)

Created:
4 years ago by Manuel Rego
Modified:
4 years ago
Reviewers:
tkent, qyearsley, foolip
CC:
chromium-reviews, blink-reviews, Dirk Pranke, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

test_converter: Avoid conversion for gzipped SVGs BUG=669452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Manuel Rego
This is just a quick fix to be able to import css-ui-3/ test suite. Feel ...
4 years ago (2016-11-29 12:21:07 UTC) #2
Manuel Rego
On 2016/11/29 12:21:07, Manuel Rego wrote: > This is just a quick fix to be ...
4 years ago (2016-11-29 12:33:10 UTC) #3
foolip
lgtm
4 years ago (2016-11-29 13:03:44 UTC) #5
Manuel Rego
Thanks for the review, but I followed a different approach as I'm skipping this svgz ...
4 years ago (2016-11-29 13:10:48 UTC) #6
foolip
4 years ago (2016-11-29 14:13:55 UTC) #7
Message was sent while issue was closed.
On 2016/11/29 13:10:48, Manuel Rego wrote:
> Thanks for the review, but I followed a different approach
> as I'm skipping this svgz file in:
> https://codereview.chromium.org/2539753002/
> 
> As that seems to work, I think we don't need to land this.

Yeah, I saw the comments only after reviewing :)

Powered by Google App Engine
This is Rietveld 408576698