Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2536153002: [scopes] Propagate inner-scope-calls-eval to make sure we context allocate in inserted scopes (Closed)

Created:
4 years ago by Toon Verwaest
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[scopes] Propagate inner-scope-calls-eval to make sure we context allocate in inserted scopes BUG=v8:5664 Committed: https://crrev.com/73a2d63df8a8da75a740a77b39d4853c4e2a4a40 Cr-Commit-Position: refs/heads/master@{#41353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/ast/scopes.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-5664.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Toon Verwaest
ptal
4 years ago (2016-11-29 10:38:42 UTC) #2
marja
lgtm as this makes the test pass and no other test fail Jochen: what was ...
4 years ago (2016-11-29 10:41:25 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-11-29 11:27:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536153002/1
4 years ago (2016-11-29 11:59:42 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 12:01:20 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-29 12:01:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73a2d63df8a8da75a740a77b39d4853c4e2a4a40
Cr-Commit-Position: refs/heads/master@{#41353}

Powered by Google App Engine
This is Rietveld 408576698